Skip to content

[fix][doc] Fix typos in class PersistentReplicator and PersistentDispatcherSingleActiveConsumer #22021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hanmz
Copy link
Contributor

@hanmz hanmz commented Feb 4, 2024

Motivation

Fix typos in class PersistentReplicator and PersistentDispatcherSingleActiveConsumer

Modifications

The past participle of the word rewind is rewound rather than rewinded

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Feb 4, 2024
@dao-jun dao-jun added this to the 3.3.0 milestone Mar 2, 2024
@dao-jun dao-jun closed this Mar 2, 2024
@dao-jun dao-jun reopened this Mar 2, 2024
@coderzc coderzc modified the milestones: 3.3.0, 3.4.0 May 8, 2024
@lhotari lhotari modified the milestones: 4.0.0, 4.1.0 Oct 11, 2024
@hanmz
Copy link
Contributor Author

hanmz commented Dec 9, 2024

/pulsarbot rerun-failure-checks

@hanmz hanmz closed this Dec 9, 2024
@hanmz hanmz reopened this Dec 9, 2024
@codecov-commenter
Copy link

codecov-commenter commented Dec 16, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 68.33%. Comparing base (e7c2a75) to head (422bb11).
Report is 827 commits behind head on master.

Files with missing lines Patch % Lines
...tent/PersistentDispatcherSingleActiveConsumer.java 0.00% 3 Missing ⚠️
...roker/service/persistent/PersistentReplicator.java 0.00% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (e7c2a75) and HEAD (422bb11). Click for more details.

HEAD has 10 uploads less than BASE
Flag BASE (e7c2a75) HEAD (422bb11)
unittests 8 4
inttests 6 1
systests 4 3
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #22021      +/-   ##
============================================
- Coverage     73.73%   68.33%   -5.40%     
- Complexity    32536    34296    +1760     
============================================
  Files          1863     1994     +131     
  Lines        138816   190012   +51196     
  Branches      15217    25153    +9936     
============================================
+ Hits         102356   129851   +27495     
- Misses        28589    49879   +21290     
- Partials       7871    10282    +2411     
Flag Coverage Δ
inttests 26.67% <0.00%> (+2.44%) ⬆️
systests 27.29% <0.00%> (+3.22%) ⬆️
unittests 67.49% <0.00%> (-5.51%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...roker/service/persistent/PersistentReplicator.java 63.11% <0.00%> (-4.77%) ⬇️
...tent/PersistentDispatcherSingleActiveConsumer.java 71.63% <0.00%> (+0.56%) ⬆️

... and 735 files with indirect coverage changes

@Jason918
Copy link
Contributor

close & reopen to trigger CI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants