Skip to content

[cleanup] [broker] fix doc for TransactionBuffer#isTxnAborted #21956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
liangyepianzhou merged 2 commits into from
Jan 25, 2024
Merged

[cleanup] [broker] fix doc for TransactionBuffer#isTxnAborted #21956

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2ca37d9
fix doc.
thetumbled Jan 23, 2024
55e0ea0
fix.
thetumbled Jan 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions ...r-broker/src/main/java/org/apache/pulsar/broker/transaction/buffer/TransactionBuffer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,10 +139,12 @@ public interface TransactionBuffer {
CompletableFuture<Void> closeAsync();

/**
* Close the buffer asynchronously.
* Check if the txn is aborted.
* TODO: To avoid broker oom, we will load the aborted txn from snapshot on demand.
* So we need the readPosition to check if the txn is loaded.
* @param txnID {@link TxnID} txnId.
* @param readPosition the persistent position of the txn message.
* @return the txnId is aborted.
* @return whether the txn is aborted.
*/
boolean isTxnAborted(TxnID txnID, PositionImpl readPosition);

Expand Down