Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat][monitor] PIP-222: Add PartitionMetadataRequest metrics #21771

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

dao-jun
Copy link
Member

@dao-jun dao-jun commented Dec 20, 2023

PIP: #18319

Motivation

#18319

Modifications

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository: dao-jun#5

@dao-jun
Copy link
Member Author

dao-jun commented Dec 20, 2023

refers to: #18319

@dao-jun dao-jun self-assigned this Dec 20, 2023
@github-actions github-actions bot added the doc-required Your PR changes impact docs and you will update later. label Dec 20, 2023
@dao-jun dao-jun added area/broker area/metrics and removed doc-required Your PR changes impact docs and you will update later. labels Dec 20, 2023
@github-actions github-actions bot added the doc-required Your PR changes impact docs and you will update later. label Dec 20, 2023
@dao-jun dao-jun requested review from eolivelli and lhotari December 20, 2023 20:12
@dao-jun dao-jun changed the title PIP-222: [feat][monitor] Add PartitionMetadataRequest metrics [feat][monitor] PIP-222: Add PartitionMetadataRequest metrics Dec 20, 2023
@Technoboy- Technoboy- modified the milestones: 3.2.0, 3.3.0 Dec 22, 2023
@dao-jun dao-jun closed this Feb 29, 2024
@dao-jun dao-jun reopened this Feb 29, 2024
@github-actions github-actions bot removed the type/PIP label Feb 29, 2024
@github-actions github-actions bot removed the type/PIP label Feb 29, 2024
@dao-jun
Copy link
Member Author

dao-jun commented Feb 29, 2024

@lhotari Please also take a look at this PR, is has been blocked for a long time

@coderzc coderzc modified the milestones: 3.3.0, 3.4.0 May 8, 2024
@lhotari lhotari removed this from the 4.0.0 milestone Oct 11, 2024
@lhotari lhotari added this to the 4.1.0 milestone Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/broker area/metrics doc-required Your PR changes impact docs and you will update later. ready-to-test release/4.0.2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants