[improve][broker] cleanup the empty subscriptionAuthenticationMap in zk when revoke subscription permission #21696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Technoboy-
approved these changes
Dec 8, 2023
nodece
reviewed
Dec 8, 2023
pulsar-broker/src/test/java/org/apache/pulsar/client/api/AuthenticatedProducerConsumerTest.java
Outdated
Show resolved
Hide resolved
nodece
reviewed
Dec 8, 2023
pulsar-broker/src/test/java/org/apache/pulsar/client/api/AuthenticatedProducerConsumerTest.java
Outdated
Show resolved
Hide resolved
nodece
reviewed
Dec 8, 2023
pulsar-broker/src/test/java/org/apache/pulsar/client/api/AuthenticatedProducerConsumerTest.java
Outdated
Show resolved
Hide resolved
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #21696 +/- ##
=============================================
+ Coverage 36.67% 73.37% +36.70%
- Complexity 12248 32756 +20508
=============================================
Files 1716 1893 +177
Lines 131166 140769 +9603
Branches 14330 15507 +1177
=============================================
+ Hits 48104 103292 +55188
+ Misses 76644 29365 -47279
- Partials 6418 8112 +1694
Flags with carried forward coverage won't be shown. Click here to find out more.
|
liudezhi2098
approved these changes
Dec 13, 2023
Technoboy-
added a commit
that referenced
this pull request
Dec 14, 2023
…zk when revoke subscription permission (#21696) Co-authored-by: fanjianye <fanjianye@bigo.sg> Co-authored-by: Jiwe Guo <technoboy@apache.org>
|
The method |
|
@horizonzy Fix getTlsFileForClient not exist in branch-3.0. #21744 |
Technoboy-
added a commit
that referenced
this pull request
Jan 3, 2024
…zk when revoke subscription permission (#21696) Co-authored-by: fanjianye <fanjianye@bigo.sg> Co-authored-by: Jiwe Guo <technoboy@apache.org>
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jan 4, 2024
…zk when revoke subscription permission (apache#21696) Co-authored-by: fanjianye <fanjianye@bigo.sg> Co-authored-by: Jiwe Guo <technoboy@apache.org> (cherry picked from commit b7d3a9c)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jan 8, 2024
…zk when revoke subscription permission (apache#21696) Co-authored-by: fanjianye <fanjianye@bigo.sg> Co-authored-by: Jiwe Guo <technoboy@apache.org> (cherry picked from commit b7d3a9c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This is a similar improve as #16815 . After we revoke subscription permission, we would see zk still remain many empty record.
Modifications
If isEmpty, remove the record in zk.
Verifying this change
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: