-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix][broker] Fix returns wrong webServiceUrl when both webServicePort and webServicePortTls are set #21633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cePortTls are set
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #21633 +/- ##
============================================
- Coverage 36.75% 36.46% -0.30%
+ Complexity 12215 782 -11433
============================================
Files 1715 1716 +1
Lines 131076 137700 +6624
Branches 14314 15457 +1143
============================================
+ Hits 48182 50213 +2031
- Misses 76498 80898 +4400
- Partials 6396 6589 +193
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Technoboy-
approved these changes
Dec 4, 2023
poorbarcode
approved these changes
Dec 4, 2023
4 tasks
mukesh-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Mar 1, 2024
…t and webServicePortTls are set (apache#21633) Co-authored-by: Jiwe Guo <technoboy@apache.org> (cherry picked from commit f8067b5) (cherry picked from commit 91e073d)
mukesh-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Mar 1, 2024
…rvicePort and webServicePortTls are set (apache#21633)" This reverts commit 91e073d. (cherry picked from commit 5e0b424)
mukesh-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Mar 1, 2024
…t and webServicePortTls are set (apache#21633) Co-authored-by: Jiwe Guo <technoboy@apache.org> (cherry picked from commit f8067b5) (cherry picked from commit ba1f8a1)
mukesh-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Mar 6, 2024
…t and webServicePortTls are set (apache#21633) Co-authored-by: Jiwe Guo <technoboy@apache.org> (cherry picked from commit f8067b5) (cherry picked from commit 91e073d)
mukesh-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Mar 6, 2024
…rvicePort and webServicePortTls are set (apache#21633)" This reverts commit 91e073d. (cherry picked from commit 5e0b424)
mukesh-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Mar 6, 2024
…t and webServicePortTls are set (apache#21633) Co-authored-by: Jiwe Guo <technoboy@apache.org> (cherry picked from commit f8067b5) (cherry picked from commit ba1f8a1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/broker
cherry-picked/branch-3.0
cherry-picked/branch-3.1
doc-not-needed
Your PR changes do not impact docs
ready-to-test
release/3.0.3
release/3.1.3
type/bug
The PR fixed a bug or issue reported a bug
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
If webServicePort and webServicePortTls are set at the same time and create an admin using webServiceAddress to access the topic, you will be stuck in an infinite redirect, the root cause is that the webServiceUrl always returns an https url even if the request is HTTP.
Modifications
Using
pulsar.getWebServiceAddress()
instead ofpulsar.getSafeWebServiceAddress()
pass towebServiceUrl
when building LocalBrokerData/NamespaceEphemeralData/BrokerLookupData.Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Documentation
doc
doc-required
doc-not-needed
doc-complete
Matching PR in forked repository
PR in forked repository: