Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve][test]Support test metadatastore of etcd with url and not testcontainers #21251

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

liangyuanpeng
Copy link
Contributor

@liangyuanpeng liangyuanpeng commented Sep 26, 2023

Fixes #21252

Main Issue: #xyz

PIP: #xyz

Motivation

Support test metadatastore of etcd with url and not testcontainers

Mainly I hope to test the metadata store etcd without a docker environment.

Modifications

Add a properties of pulsar.metadatastore.etcd.url for run metadata store etcd test.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

Signed-off-by: Lan Liang <gcslyp@gmail.com>
@liangyuanpeng liangyuanpeng changed the title 'Support test metadatastore of etcd with url and not testcontainers [imporve][metadatastore]Support test metadatastore of etcd with url and not testcontainers Sep 26, 2023
@github-actions
Copy link

@liangyuanpeng Please add the following content to your PR description and select a checkbox:

- [ ] `doc` <!-- Your PR contains doc changes -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->

@github-actions github-actions bot added doc-not-needed Your PR changes do not impact docs and removed doc-label-missing labels Sep 26, 2023
@Technoboy- Technoboy- changed the title [imporve][metadatastore]Support test metadatastore of etcd with url and not testcontainers [improve][test]Support test metadatastore of etcd with url and not testcontainers Sep 26, 2023
@Technoboy- Technoboy- added this to the 3.2.0 milestone Sep 26, 2023
if(!StringUtils.isBlank(etcdUrl)){
return "etcd:"+etcdUrl;
}
@Cleanup
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The @Cleanup should call the close(), which seems to cause the etcd cluster to shutdown after calling the getEtcdClusterConnectString().

@github-actions
Copy link

The pr had no activity for 30 days, mark with Stale label.

@github-actions github-actions bot added the Stale label Oct 28, 2023
@Technoboy- Technoboy- modified the milestones: 3.2.0, 3.3.0 Dec 22, 2023
@coderzc coderzc modified the milestones: 3.3.0, 3.4.0 May 8, 2024
@lhotari lhotari modified the milestones: 4.0.0, 4.1.0 Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Metadatastore etcd support test with url and not testcontainers
5 participants