-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[improve][test]Support test metadatastore of etcd with url and not testcontainers #21251
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Lan Liang <gcslyp@gmail.com>
@liangyuanpeng Please add the following content to your PR description and select a checkbox:
|
if(!StringUtils.isBlank(etcdUrl)){ | ||
return "etcd:"+etcdUrl; | ||
} | ||
@Cleanup |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The @Cleanup
should call the close()
, which seems to cause the etcd cluster to shutdown after calling the getEtcdClusterConnectString()
.
The pr had no activity for 30 days, mark with Stale label. |
Fixes #21252
Main Issue: #xyz
PIP: #xyz
Motivation
Support test metadatastore of etcd with url and not testcontainers
Mainly I hope to test the metadata store etcd without a docker environment.
Modifications
Add a properties of
pulsar.metadatastore.etcd.url
for run metadata store etcd test.Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
doc
doc-required
doc-not-needed
doc-complete
Matching PR in forked repository
PR in forked repository: