[fix][broker]Delete subscription and disconnect replicators after topic migration #21029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/pulsarbot run-failure-checks |
2 similar comments
|
/pulsarbot run-failure-checks |
|
/pulsarbot run-failure-checks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Right now after we mark the topic migrated, replicators do not get disconnected from blue cluster and subscriptions are not deleted even after the backlog is drained and all consumers are disconnected. This pr takes care of this by asynchronously disconnecting replicators and deleting subscriptions once the backlog is drained and all consumers are disconnected when checkClusterMigration API is called.
Modifications
Replicators without backlog are disconnected and subscriptions without consumers are deleted and eventually topic is garbage collected in the blue cluster.
Call checkAndDisconnectReplicators() and checkAndUnsubscribeSubscriptions() in checkClusterMigration() periodic job.
Verifying this change
This change added tests and can be verified as follows:
Added unit tests to verify the change
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-complete