[improve] [ws] add cryptoKeyReaderFactoryClassName into the file websocket.conf #20840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poorbarcode
requested review from
Technoboy-,
gaoran10,
coderzc and
liangyepianzhou
gaoran10
approved these changes
Jul 20, 2023
Technoboy-
approved these changes
Jul 20, 2023
Codecov Report
@@ Coverage Diff @@
## master #20840 +/- ##
============================================
+ Coverage 72.75% 73.12% +0.37%
+ Complexity 32235 32171 -64
============================================
Files 1856 1868 +12
Lines 138999 139188 +189
Branches 15302 15315 +13
============================================
+ Hits 101128 101786 +658
+ Misses 29860 29323 -537
- Partials 8011 8079 +68
Flags with carried forward coverage won't be shown. Click here to find out more. |
poorbarcode
added a commit
that referenced
this pull request
Jul 20, 2023
…ocket.conf (#20840) Motivation: Since the PR #16234 add the prop `cryptoKeyReaderFactoryClassName` for the WebSocket Proxy, but did not add this prop to `websocket.conf`. This can make the script which try to replacement attribute a bit difficult to write Modifications: add the conf `cryptoKeyReaderFactoryClassName` into the file `websocket.conf` (cherry picked from commit 5d0aa56)
Technoboy-
pushed a commit
that referenced
this pull request
Aug 17, 2023
…ocket.conf (#20840) Motivation: Since the PR #16234 add the prop `cryptoKeyReaderFactoryClassName` for the WebSocket Proxy, but did not add this prop to `websocket.conf`. This can make the script which try to replacement attribute a bit difficult to write Modifications: add the conf `cryptoKeyReaderFactoryClassName` into the file `websocket.conf`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Since the PR #16234 add the prop
cryptoKeyReaderFactoryClassNamefor the WebSocket Proxy, but did not add this prop towebsocket.conf. This can make the script which try to replacement attribute a bit difficult to writeModifications
add the conf
cryptoKeyReaderFactoryClassNameinto the filewebsocket.confDocumentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: x