[pip][design] PIP-279: Reformat property in generateResponseWithEntry #20627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StevenLuMT
changed the title
eolivelli
reviewed
Jun 21, 2023
pip/pip-279.md
Outdated
| when we run `bin/pulsar-admin topics get-message-by-id `, it will throw exception, the exception is: | ||
| `Reason: java.util.concurrent.CompletionException: org.apache.pulsar.client.admin.internal.http.AsyncHttpConnector$RetryException: Could not complete the operation. Number of retries has been exhausted. Failed reason: a header name cannot contain the following prohibited characters: =,;: \t\r\n\v\f: =` | ||
|
|
||
| <img width="1288" alt="image" src="https://github.com/StevenLuMT/pulsar/assets/42990025/973d95b9-4ac2-4977-b160-162c4b53a613"> |
There was a problem hiding this comment.
Please don't link images not hosted in this repo
There was a problem hiding this comment.
Please don't link images not hosted in this repo
ok,updated thanks @eolivelli
Technoboy-
changed the title
15 tasks
Technoboy-
approved these changes
Jul 24, 2023
gaoran10
reviewed
Jul 24, 2023
AnonHxy
approved these changes
Jul 27, 2023
AnonHxy
approved these changes
Jul 27, 2023
RobertIndie
pushed a commit
to apache/pulsar-client-go
that referenced
this pull request
Oct 24, 2024
### Motivation After [pip-279](apache/pulsar#20627), all properties keys and values use json string save to header: `X-Pulsar-Property` This PR to compatible with this change when using subscription admin API. Also, Using `pip-279` also avoids the issue where the Go HTTP client automatically formats HTTP headers: golang/go#37834, This will impact the peek command, the previous method might retrieve `properties` with inconsistent casing compared to the user-defined. ### Modifications - Compatible the HTTP header properties with PIP-279
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This is a PIP to reformat property in generateResponseWithEntry. The PR contents have the motivation.
Documentation
doc-not-neededMatching PR in forked repository
PR in forked repository: #20481