Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix][broker] Fix flaky test - testClusterMigrationWithReplica… #20379

Merged
merged 1 commit into from
May 24, 2023

Conversation

vineeth1995
Copy link
Contributor

@vineeth1995 vineeth1995 commented May 23, 2023

Motivation

Fixes issue #20375
Fix the flaky test case introduced by this pr - #19605

Modifications

Publish a message before asserting that producer is connected to green cluster as this will force the producer to connect to green cluster instead of waiting until retry.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label May 23, 2023
@vineeth1995 vineeth1995 changed the title [fix][pulsar-broker] Fix flaky test - testClusterMigrationWithReplica… [Fix][pulsar-broker] Fix flaky test - testClusterMigrationWithReplica… May 23, 2023
@vineeth1995 vineeth1995 changed the title [Fix][pulsar-broker] Fix flaky test - testClusterMigrationWithReplica… [fix][broker] Fix flaky test - testClusterMigrationWithReplica… May 23, 2023
@vineeth1995
Copy link
Contributor Author

/pulsarbot rerun-failure-checks

1 similar comment
@lhotari
Copy link
Member

lhotari commented May 24, 2023

/pulsarbot rerun-failure-checks

@lhotari lhotari merged commit aff4a1c into apache:master May 24, 2023
@Technoboy- Technoboy- added this to the 3.1.0 milestone May 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/test doc-not-needed Your PR changes do not impact docs ready-to-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants