Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix][broker] Fix broker immediately redirect migration eligible consumers #20351

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rdhabalia
Copy link
Contributor

@rdhabalia rdhabalia commented May 19, 2023

Motivation

Right now, when broker marks topic migrated during blue-green cluster migration then broker disconnects consumers of the subscriptions once it reaches end of managed-leger data and consumer will be redirected to green cluster. However, if consumer is connected to topic without any backlog then consumer stays connected and broker didn't trigger consumer migration or it delays newly connected consumers which are eligible to redirect to new green cluster. Therefore, this PR makes sure that all the consumers of subscriptions which are not having backlog will be migrated and broker also checks topic migration when new consumer connects and notifies those consumers immediately if there is no backlog on that subscription.

Result

Consumers will be redirected to migrated cluster immediately if the subscription doesn't have any backlog.

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

@rdhabalia rdhabalia added area/broker doc-not-needed Your PR changes do not impact docs ready-to-test labels May 19, 2023
@rdhabalia rdhabalia added this to the 3.1.0 milestone May 19, 2023
@rdhabalia rdhabalia self-assigned this May 19, 2023
@github-actions
Copy link

The pr had no activity for 30 days, mark with Stale label.

@github-actions github-actions bot added the Stale label Jun 18, 2023
@Technoboy- Technoboy- modified the milestones: 3.1.0, 3.2.0 Jul 31, 2023
@Technoboy- Technoboy- modified the milestones: 3.2.0, 3.3.0 Dec 22, 2023
@coderzc coderzc modified the milestones: 3.3.0, 3.4.0 May 8, 2024
@lhotari lhotari modified the milestones: 4.0.0, 4.1.0 Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants