Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat][meta] Upgrade to jetcd to 0.7.5 #20339

Merged
merged 1 commit into from
May 17, 2023

Conversation

michaeljmarshall
Copy link
Member

Fixes #20308

Motivation

As described in #20308, we have test flakiness because of an issue in the etcd dependency. This PR upgrades etcd to fix the test.

I am not familiar with this integration. If there is any reason we should avoid this upgrade, please comment as much.

Modifications

  • Upgrade etcd dependency from 0.5.11 to 0.7.5
  • Update license files
  • Increase test timeout since it was failing during docker pull on my local machine
  • Replace code with the new methods/classes

Verifying this change

Tests passing should be sufficient.

Documentation

  • doc-not-needed

Matching PR in forked repository

PR in forked repository: michaeljmarshall#49

@michaeljmarshall michaeljmarshall added type/flaky-tests doc-not-needed Your PR changes do not impact docs area/metadata dependencies Pull requests that update a dependency file labels May 17, 2023
@michaeljmarshall michaeljmarshall added this to the 3.1.0 milestone May 17, 2023
@michaeljmarshall michaeljmarshall self-assigned this May 17, 2023
@lhotari
Copy link
Member

lhotari commented May 17, 2023

/pulsarbot rerun-failure-checks

@codecov-commenter
Copy link

codecov-commenter commented May 17, 2023

Codecov Report

Merging #20339 (35dccce) into master (426ad3e) will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #20339      +/-   ##
============================================
- Coverage     72.93%   72.90%   -0.04%     
+ Complexity    31973    31951      -22     
============================================
  Files          1868     1868              
  Lines        138663   138663              
  Branches      15248    15248              
============================================
- Hits         101133   101086      -47     
- Misses        29484    29519      +35     
- Partials       8046     8058      +12     
Flag Coverage Δ
inttests 24.18% <ø> (+0.06%) ⬆️
systests 24.91% <ø> (+0.05%) ⬆️
unittests 72.18% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ache/pulsar/broker/loadbalance/LinuxInfoUtils.java 43.65% <ø> (ø)
...ker/loadbalance/impl/LinuxBrokerHostUsageImpl.java 79.68% <ø> (-4.69%) ⬇️

... and 66 files with indirect coverage changes

@lhotari lhotari merged commit c7a4060 into apache:master May 17, 2023
@tisonkun
Copy link
Member

Error:  jetcd-core-0.7.5.jar: CVE-2020-15113(7.1)
Error:  jetcd-grpc-0.7.5.jar: CVE-20[17](https://github.com/apache/pulsar/actions/runs/4999756027/jobs/8959140598#step:10:18)-8359(9.8), CVE-2020-15113(7.1), CVE-2020-7768(9.8), CVE-2017-7861(9.8), CVE-2017-9431(9.8), CVE-2017-7860(9.8)

We may need new suppression rules @lhotari @michaeljmarshall

@michaeljmarshall
Copy link
Member Author

I'll add those.

@poorbarcode
Copy link
Contributor

@michaeljmarshall I am releasing 3.0.2, and the license check can not pass.

The dependency's version of animal-sniffer-annotations is 1.21 now, but the license of presto(trino) is still 1.19

see: https://github.com/apache/pulsar/actions/runs/6627474211/job/18019187456?pr=21435

Run src/check-binary-license.sh ./distribution/server/target/apache-pulsar-*-bin.tar.gz && src/check-binary-license.sh ./distribution/shell/target/apache-pulsar-shell-*-bin.tar.gz
  src/check-binary-license.sh ./distribution/server/target/apache-pulsar-*-bin.tar.gz && src/check-binary-license.sh ./distribution/shell/target/apache-pulsar-shell-*-bin.tar.gz
  shell: /usr/bin/bash -e {0}
  env:
    MAVEN_OPTS: -Xss1500k -Xmx1024m -Daether.connector.http.reuseConnections=false -Daether.connector.requestTimeout=60000 -Dhttp.keepAlive=false -Dmaven.wagon.http.pool=false -Dmaven.wagon.http.retryHandler.class=standard -Dmaven.wagon.http.retryHandler.count=3 -Dmaven.wagon.http.retryHandler.requestSentEnabled=true -Dmaven.wagon.http.serviceUnavailableRetryStrategy.class=standard -Dmaven.wagon.rto=60000
    ARTIFACT_RETENTION_DAYS: 3
    GRADLE_ENTERPRISE_ACCESS_KEY: 
    JAVA_HOME: /opt/hostedtoolcache/Java_Temurin-Hotspot_jdk/17.0.8-1/x64
    JAVA_HOME_17_X64: /opt/hostedtoolcache/Java_Temurin-Hotspot_jdk/17.0.8-1/x64
    ACTIONS_RUNTIME_TOKEN: ***
    ACTIONS_RUNTIME_URL: https://pipelinesghubeus21.actions.githubusercontent.com/EXIZfX8ixSbQEfqDA00dMJrEtloTMSwjlUs9NqJqrTcJfd7NaR/
    UBUNTU_MIRROR: http://azure.archive.ubuntu.com/ubuntu/
    UBUNTU_SECURITY_MIRROR: http://azure.archive.ubuntu.com/ubuntu/
src/check-binary-license.sh: line 69: echo: write error: Broken pipe
src/check-binary-license.sh: line 69: echo: write error: Broken pipe
animal-sniffer-annotations-1.21.jar unaccounted for in trino/LICENSE
animal-sniffer-annotations-1.19.jar mentioned in trino/LICENSE, but not bundled

It looks like there are issues with the LICENSE/NOTICE.
Error: Process completed with exit code 2.

I saw this PR removed this line, I want to cherry-pick this PR to branch-3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/metadata cherry-picked/branch-3.0 dependencies Pull requests that update a dependency file doc-not-needed Your PR changes do not impact docs release/3.0.2 type/flaky-tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flaky-test: LeaderElectionImplTest.validateDeadLock
5 participants