Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve][broker] Move bitmap from lastMutableBucket to ImmutableBucket #20156

Merged
merged 7 commits into from
Apr 21, 2023

Conversation

coderzc
Copy link
Member

@coderzc coderzc commented Apr 20, 2023

PIP: #16763

Motivation & Modifications

Move bitmap from lastMutableBucket to ImmutableBucket

Avoid bitmap copy from byte[] to ByteString

Increase recovery timeout time

Verifying this change

  • Make sure that the change passes the CI checks.

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

@coderzc coderzc self-assigned this Apr 20, 2023
@coderzc coderzc added type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages area/broker labels Apr 20, 2023
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Apr 20, 2023
@coderzc coderzc requested a review from mattisonchao April 20, 2023 14:51
@coderzc coderzc closed this Apr 21, 2023
@coderzc coderzc reopened this Apr 21, 2023
@coderzc coderzc force-pushed the improve_bucket_delayed_bitmap_move branch from 30a6fd9 to 8af7aca Compare April 21, 2023 04:30
@coderzc coderzc merged commit e5a833a into apache:master Apr 21, 2023
@coderzc coderzc added this to the 3.1.0 milestone Apr 21, 2023
@coderzc coderzc deleted the improve_bucket_delayed_bitmap_move branch April 21, 2023 10:14
poorbarcode pushed a commit that referenced this pull request May 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/broker cherry-picked/branch-3.0 doc-not-needed Your PR changes do not impact docs ready-to-test release/3.0.1 type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants