-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix][cli] Fix logging noise while admin tool exit #19884
Conversation
Since we will start the RC version of
So drag this PR to |
/pulsarbot rerun-failure-checks |
The pr had no activity for 30 days, mark with Stale label. |
I like this change. Let me see if I can help nudge this patch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
I was about to send a similar patch
Thanks
Merging.. Thanks for taking care of this! |
Co-authored-by: tison <wander4096@gmail.com> (cherry picked from commit ad352a9)
Motivation
Pulsar admin tool unnecessary logs noise while existing the process which gives bad user experience and should be removed.
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
doc
doc-required
doc-not-needed
doc-complete
Matching PR in forked repository
PR in forked repository: