-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[improve][cli] topic offline internal-info provide schema ledger info #19883
base: master
Are you sure you want to change the base?
Conversation
Since we will start the RC version of
So drag this PR to |
The pr had no activity for 30 days, mark with Stale label. |
@@ -1455,6 +1457,22 @@ public void getInfoFailed(ManagedLedgerException exception, Object ctx) { | |||
return null; | |||
}); | |||
|
|||
// Schema store ledgers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@liudezhi2098 I remember you have similar experience in debugging meta infos. Do you think this patch is good to go? I'm a bit uncertain due to it add a heavy operation on CLI command.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a bit uncertain due to it add a heavy operation on CLI command.
heavy operation? CLI command is client tool and it just prints the output at client side which should not cause any heavy CPU/IP/Memroy pressure.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #19883 +/- ##
============================================
+ Coverage 73.57% 74.50% +0.93%
- Complexity 32624 34549 +1925
============================================
Files 1877 1938 +61
Lines 139502 145456 +5954
Branches 15299 15898 +599
============================================
+ Hits 102638 108378 +5740
+ Misses 28908 28766 -142
- Partials 7956 8312 +356
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Motivation
There are many cases when a broker is not able to load the topic successfully and it requires examining the metadata of topic/schema/managed-ledger etc for example: #19882 . But all such metadata is stored in binary in metadata/zk and it really requires to broker admin API to fetch internal info of the topic. Therefore, issue like in PR# 19882 requires users to retrieve schema ledger metadata for further debugging even if topic is not successfully loaded. so, add topic's schema metadata into topic's internal-info API which doesn't depend on loaded topic.
Modifications
Add schema ledger metadata into topics' offline internal-metadata api.
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
doc
doc-required
doc-not-needed
doc-complete
Matching PR in forked repository
PR in forked repository: