[fix][ci] Require coverage upload jobs to succeed before deleting intermediate build artifacts #19305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhotari
force-pushed
the
lh-require-coverage-upload-jobs-to-succeed
branch
from
aad0adb to
f7e9b44
Compare
lhotari
force-pushed
the
lh-require-coverage-upload-jobs-to-succeed
branch
from
f7e9b44 to
18354c9
Compare
tisonkun
approved these changes
Jan 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Uploading coverage to Codecov might fail. Uploading requires the intermediate pulsar-maven-repository-binaries.tar.zst so this shouldn't be deleted if one of the upload jobs has failed.
Modifications
Add proper condition to deletion step. This PR will also skip deletion if owasp-dep-check or flaky-systems-tests fail.
Documentation
docdoc-requireddoc-not-neededdoc-complete