[improve][ci] Improve CI ssh access in forks, don't fail build if setting up ssh access fails #19127
+24
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhotari
force-pushed
the
lh-improve-ci-ssh-access-in-forks
branch
from
a6e6bba to
6d8ca0a
Compare
lhotari
force-pushed
the
lh-improve-ci-ssh-access-in-forks
branch
3 times, most recently
from
151480c to
0ca1168
Compare
…ting up ssh access fails - address error message "flag needs an argument: --admin-socket" - wait up to 10 seconds for admin socket to appear - add "continue-on-error: true" to ssh setup step so that errors don't prevent the build from continuing
lhotari
force-pushed
the
lh-improve-ci-ssh-access-in-forks
branch
from
0ca1168 to
d56a9c1
Compare
|
/pulsarbot rerun-failure-checks |
Codecov Report
@@ Coverage Diff @@
## master #19127 +/- ##
============================================
- Coverage 47.73% 47.34% -0.39%
+ Complexity 10819 10716 -103
============================================
Files 712 712
Lines 69645 69645
Branches 7481 7481
============================================
- Hits 33242 32975 -267
- Misses 32699 32963 +264
- Partials 3704 3707 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
Merging... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The ssh access setup step that is part of Pulsar CI can fail in builds that are run in forks. The ssh access feature is active in CI builds run in forks to allow connecting to the running build with ssh for debugging purposes.
This is the ssh access setup step:
https://github.com/apache/pulsar/blob/master/.github/workflows/pulsar-ci.yaml#L88-L93
Sometime this fails with an error message "flag needs an argument: --admin-socket". Example of failure:
https://github.com/michaeljmarshall/pulsar/actions/runs/3833202322/jobs/6527659487#step:4:150
Modifications
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: lhotari#122