Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix][cli] Fix wrong description of pulsar-admin flags #19108

Merged
merged 1 commit into from
Dec 30, 2022

Conversation

maxsxu
Copy link
Contributor

@maxsxu maxsxu commented Dec 30, 2022

Motivation

pulsar-admin sources list has the wrong parameters description.

Modifications

Should be pulsar-admin sources list --namespace <The source's namespace> --tenant <The source's tenant>

Verifying this change

  • Make sure that the change passes the CI checks.

This change is a trivial rework / code cleanup without any test coverage.

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Signed-off-by: Max Xu <maxs.xu@gmail.com>
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Dec 30, 2022
@codelipenghui codelipenghui added this to the 2.12.0 milestone Dec 30, 2022
@codecov-commenter
Copy link

codecov-commenter commented Dec 30, 2022

Codecov Report

Merging #19108 (2626e77) into master (62a2058) will increase coverage by 1.88%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #19108      +/-   ##
============================================
+ Coverage     45.63%   47.52%   +1.88%     
+ Complexity    11013    10768     -245     
============================================
  Files           772      712      -60     
  Lines         74313    69541    -4772     
  Branches       7998     7466     -532     
============================================
- Hits          33915    33049     -866     
+ Misses        36604    32796    -3808     
+ Partials       3794     3696      -98     
Flag Coverage Δ
unittests 47.52% <100.00%> (+1.88%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...che/bookkeeper/mledger/impl/ManagedLedgerImpl.java 54.34% <100.00%> (+0.30%) ⬆️
...java/org/apache/pulsar/proxy/stats/TopicStats.java 58.82% <0.00%> (-41.18%) ⬇️
...ction/buffer/impl/TransactionBufferClientImpl.java 76.74% <0.00%> (-4.66%) ⬇️
.../buffer/impl/TransactionBufferClientStatsImpl.java 82.00% <0.00%> (-4.00%) ⬇️
...pulsar/broker/TransactionMetadataStoreService.java 58.51% <0.00%> (-3.94%) ⬇️
...rg/apache/pulsar/broker/service/AbstractTopic.java 62.06% <0.00%> (-3.00%) ⬇️
...tion/buffer/impl/TransactionBufferHandlerImpl.java 50.00% <0.00%> (-2.54%) ⬇️
...he/pulsar/broker/admin/v2/NonPersistentTopics.java 60.64% <0.00%> (-1.39%) ⬇️
...sar/broker/loadbalance/impl/LoadManagerShared.java 43.85% <0.00%> (-1.32%) ⬇️
...rg/apache/pulsar/broker/web/PulsarWebResource.java 56.31% <0.00%> (-1.10%) ⬇️
... and 91 more

@315157973 315157973 merged commit 36cff70 into apache:master Dec 30, 2022
@maxsxu maxsxu deleted the fix branch December 30, 2022 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-not-needed Your PR changes do not impact docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants