[fix][build] Include Pulsar shell in the released artifacts #18583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems the release action of 2.11.0 is performed against branch-2.11 so we need a cherry-pick. Also, cc @Technoboy- as the release manager of 2.11.0 FYI. |
Codecov Report
@@ Coverage Diff @@
## master #18583 +/- ##
============================================
+ Coverage 36.82% 45.63% +8.81%
- Complexity 7842 9863 +2021
============================================
Files 698 672 -26
Lines 68060 65824 -2236
Branches 7277 7034 -243
============================================
+ Hits 25062 30042 +4980
+ Misses 39675 32365 -7310
- Partials 3323 3417 +94
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Technoboy-
approved these changes
Nov 24, 2022
codelipenghui
approved these changes
Nov 24, 2022
tisonkun
approved these changes
Nov 24, 2022
There was a problem hiding this comment.
Merging...
@nicoloboschi @Technoboy- how do you think this patch should be cherry-picked to branch-2.11?
I will do this. |
Technoboy-
pushed a commit
that referenced
this pull request
Nov 24, 2022
lifepuzzlefun
pushed a commit
to lifepuzzlefun/pulsar
that referenced
this pull request
Dec 9, 2022
lifepuzzlefun
pushed a commit
to lifepuzzlefun/pulsar
that referenced
this pull request
Jan 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The current release process doesn't stage the pulsar shell artifacts. Pulsar shell is going to be released in 2.11.0
Modifications
docdoc-requireddoc-not-neededdoc-completenote: we should update the release process in the pulsar-site repository.