[fix][doc] Fix the note of seek in the consumer #18476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation We already added the seek support for multi-topics consumer in apache#7518. But the note for seek method haven't been updated. Modification * Update the doc for seek method in the consumer. Signed-off-by: Zike Yang <zike@apache.org>
RobertIndie
added
type/bug
codelipenghui
approved these changes
Nov 15, 2022
|
/pulsarbot run-failure-checks |
Codecov Report
@@ Coverage Diff @@
## master #18476 +/- ##
=============================================
+ Coverage 31.39% 46.99% +15.59%
- Complexity 6651 10399 +3748
=============================================
Files 697 697
Lines 68015 68023 +8
Branches 7285 7284 -1
=============================================
+ Hits 21353 31966 +10613
+ Misses 43667 32492 -11175
- Partials 2995 3565 +570
Flags with carried forward coverage won't be shown. Click here to find out more.
|
nodece
approved these changes
Nov 16, 2022
coderzc
approved these changes
Nov 17, 2022
lifepuzzlefun
pushed a commit
to lifepuzzlefun/pulsar
that referenced
this pull request
Dec 9, 2022
### Motivation We already added the seek support for multi-topics consumer in apache#7518. But the note for seek method hasn't been updated. ### Modifications * Update the doc for seek method in the consumer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We already added the seek support for multi-topics consumer in #7518. But the note for seek method hasn't been updated.
Modifications
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: