-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[improve][txn] Avoid txn id primitive auto boxing #18270
[improve][txn] Avoid txn id primitive auto boxing #18270
Conversation
`TxnID` `equals` and `hashCode`
`TxnID` `equals` and `hashCode`
@codelipenghui @Technoboy- please take a look, thank you~ |
simple jmh test result
|
/pulsarbot run-failure-checks |
fix code style
Codecov Report
@@ Coverage Diff @@
## master #18270 +/- ##
============================================
- Coverage 38.97% 33.04% -5.93%
+ Complexity 8311 4391 -3920
============================================
Files 683 400 -283
Lines 67325 43611 -23714
Branches 7217 4476 -2741
============================================
- Hits 26239 14411 -11828
+ Misses 38079 27070 -11009
+ Partials 3007 2130 -877
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch!
Fixes #18271
Motivation
avoid txnid auto box long type to Long in equals
Modifications
direct compare with ==
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
doc
doc-required
doc-not-needed
doc-complete