[fix][broker] do not serialize field bundleStats #18150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codelipenghui
requested review from
Demogorgon314,
mattisonchao and
Technoboy-
codelipenghui
changed the title
codelipenghui
added
type/bug
codelipenghui
changed the title
codelipenghui
changed the title
codelipenghui
removed
the
type/cleanup
pulsar-broker/src/test/java/org/apache/pulsar/broker/loadbalance/LocalBrokerDataTest.java
Outdated
Show resolved
Hide resolved
pulsar-broker/src/test/java/org/apache/pulsar/broker/loadbalance/LocalBrokerDataTest.java
Outdated
Show resolved
Hide resolved
pulsar-broker/src/test/java/org/apache/pulsar/broker/loadbalance/LocalBrokerDataTest.java
Outdated
Show resolved
Hide resolved
RobertIndie
reviewed
Oct 24, 2022
Comment on lines
31
to
33
| /* | ||
| Ensuring that there no bundleStats field in the json string serialized from LocalBrokerData. | ||
| */ |
There was a problem hiding this comment.
Suggested change
| /* | |
| Ensuring that there no bundleStats field in the json string serialized from LocalBrokerData. | |
| */ | |
| /** | |
| * Ensure that there is no bundleStats field in the json string serialized from LocalBrokerData. | |
| */ |
There was a problem hiding this comment.
i found another LocalBrokerDataTest class, so i move the implementation into it.
mattisonchao
approved these changes
Oct 24, 2022
Technoboy-
approved these changes
Oct 24, 2022
Codecov Report
@@ Coverage Diff @@
## master #18150 +/- ##
============================================
+ Coverage 34.91% 40.28% +5.36%
- Complexity 5707 15008 +9301
============================================
Files 607 1579 +972
Lines 53396 128710 +75314
Branches 5712 14152 +8440
============================================
+ Hits 18644 51852 +33208
- Misses 32119 71046 +38927
- Partials 2633 5812 +3179
Flags with carried forward coverage won't be shown. Click here to find out more.
|
codelipenghui
approved these changes
Oct 25, 2022
nodece
approved these changes
Oct 25, 2022
Demogorgon314
approved these changes
Oct 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17738
Modifications
because broker will do not use the field bundleStats, so we could do not serialize the field bundleStats.
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository:
thetumbled#3