-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix][broker] Fix RetentionPolicies types mismatch. #18114
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also should modify ManagedLedgerConfig.retentionSizeInMB
type.
pulsar/managed-ledger/src/main/java/org/apache/bookkeeper/mledger/ManagedLedgerConfig.java
Lines 437 to 440 in 7b53bd9
public ManagedLedgerConfig setRetentionSizeInMB(long retentionSizeInMB) { | |
this.retentionSizeInMB = retentionSizeInMB; | |
return this; | |
} |
applyed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report
@@ Coverage Diff @@
## master #18114 +/- ##
=============================================
+ Coverage 34.91% 46.01% +11.10%
- Complexity 5707 17682 +11975
=============================================
Files 607 1574 +967
Lines 53396 128632 +75236
Branches 5712 14159 +8447
=============================================
+ Hits 18644 59195 +40551
- Misses 32119 63327 +31208
- Partials 2633 6110 +3477
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question: Why don't we choose long
?
|
8712e18
to
afd75b3
Compare
I think we still should use the |
Fixes #18112
Motivation
Documentation
doc-not-needed