Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix][broker] Fix RetentionPolicies types mismatch. #18114

Merged
merged 3 commits into from
Oct 23, 2022

Conversation

Technoboy-
Copy link
Contributor

Fixes #18112

Motivation

Documentation

  • doc-not-needed

Copy link
Member

@coderzc coderzc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also should modify ManagedLedgerConfig.retentionSizeInMB type.

public ManagedLedgerConfig setRetentionSizeInMB(long retentionSizeInMB) {
this.retentionSizeInMB = retentionSizeInMB;
return this;
}

@Technoboy-
Copy link
Contributor Author

setRetentionSizeInMB

Also should modify ManagedLedgerConfig.retentionSizeInMB type.

public ManagedLedgerConfig setRetentionSizeInMB(long retentionSizeInMB) {
this.retentionSizeInMB = retentionSizeInMB;
return this;
}

applyed

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Oct 19, 2022
Copy link
Contributor

@lordcheng10 lordcheng10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

codecov-commenter commented Oct 19, 2022

Codecov Report

Merging #18114 (afd75b3) into master (6c65ca0) will increase coverage by 11.10%.
The diff coverage is 39.68%.

Impacted file tree graph

@@              Coverage Diff              @@
##             master   #18114       +/-   ##
=============================================
+ Coverage     34.91%   46.01%   +11.10%     
- Complexity     5707    17682    +11975     
=============================================
  Files           607     1574      +967     
  Lines         53396   128632    +75236     
  Branches       5712    14159     +8447     
=============================================
+ Hits          18644    59195    +40551     
- Misses        32119    63327    +31208     
- Partials       2633     6110     +3477     
Flag Coverage Δ
unittests 46.01% <39.68%> (+11.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../main/java/org/apache/pulsar/PulsarStandalone.java 0.00% <0.00%> (ø)
.../apache/pulsar/broker/admin/impl/ClustersBase.java 76.66% <0.00%> (+67.62%) ⬆️
...pache/pulsar/broker/admin/impl/NamespacesBase.java 63.25% <ø> (+48.72%) ⬆️
.../pulsar/broker/service/AbstractBaseDispatcher.java 52.14% <0.00%> (+6.28%) ⬆️
...che/pulsar/broker/service/BacklogQuotaManager.java 12.39% <0.00%> (+2.91%) ⬆️
.../pulsar/broker/service/BrokerServiceException.java 44.44% <0.00%> (+19.44%) ⬆️
...ava/org/apache/pulsar/broker/service/Consumer.java 71.63% <0.00%> (+9.62%) ⬆️
...ava/org/apache/pulsar/broker/service/Producer.java 62.72% <0.00%> (+3.08%) ⬆️
...pulsar/broker/service/PulsarCommandSenderImpl.java 74.35% <0.00%> (+7.69%) ⬆️
...va/org/apache/pulsar/broker/service/ServerCnx.java 48.71% <0.00%> (+3.37%) ⬆️
... and 1181 more

Copy link
Member

@mattisonchao mattisonchao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: Why don't we choose long?

@Technoboy-
Copy link
Contributor Author

Question: Why don't we choose long?

int is enough.

@Technoboy- Technoboy- force-pushed the fix-rt-type-mismatch branch from 8712e18 to afd75b3 Compare October 22, 2022 14:10
@Technoboy- Technoboy- merged commit c55be38 into apache:master Oct 23, 2022
@nodece
Copy link
Member

nodece commented Mar 9, 2023

Question: Why don't we choose long?

int is enough.

I think we still should use the long, long can be compatible with int.

@Technoboy- @mattisonchao

nodece added a commit to nodece/pulsar that referenced this pull request Mar 10, 2023
nodece added a commit to nodece/pulsar that referenced this pull request Mar 10, 2023
nodece added a commit to nodece/pulsar that referenced this pull request Mar 15, 2023
nodece added a commit to nodece/pulsar that referenced this pull request Mar 17, 2023
nodece added a commit to nodece/pulsar that referenced this pull request Mar 20, 2023
@Technoboy- Technoboy- deleted the fix-rt-type-mismatch branch November 11, 2023 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/broker doc-not-needed Your PR changes do not impact docs ready-to-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] RetentionPolicies types mismatch
6 participants