-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat][zk] Enable certificate refresh for Quorum and Netty Servers #18097
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
From ZK documentation:
|
Good idea to reference the ZK documentation @nodece. I updated my PR's description with it. Thanks! |
Codecov Report
@@ Coverage Diff @@
## master #18097 +/- ##
=========================================
Coverage ? 46.93%
Complexity ? 17937
=========================================
Files ? 1574
Lines ? 128342
Branches ? 14121
=========================================
Hits ? 60239
Misses ? 61908
Partials ? 6195
Flags with carried forward coverage won't be shown. Click here to find out more. |
Fixes apache/pulsar-helm-chart#285
Motivation
The current Pulsar SSL Server Contexts always reload certificates from the file system. Zookeeper supports such options, but we do not enable them by default. I propose we do that.
Apache Zookeeper documentation:
Modifications
Verifying this change
This is a trivial configuration change.
Does this pull request potentially affect one of the following parts:
I do not believe this needs a PIP because our standard default is already to refresh certificates in the broker, function worker, the proxy, and the websocket proxy.
Documentation
doc-not-needed
Matching PR in forked repository
PR in forked repository: michaeljmarshall#5