-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[improve][io] JDBC sinks: implement JDBC Batch API #18017
Conversation
pulsar-io/jdbc/core/src/main/java/org/apache/pulsar/io/jdbc/JdbcAbstractSink.java
Show resolved
Hide resolved
pulsar-io/jdbc/core/src/main/java/org/apache/pulsar/io/jdbc/JdbcAbstractSink.java
Show resolved
Hide resolved
pulsar-io/jdbc/core/src/main/java/org/apache/pulsar/io/jdbc/JdbcAbstractSink.java
Outdated
Show resolved
Hide resolved
@eolivelli please review it again |
pulsar-io/jdbc/core/src/main/java/org/apache/pulsar/io/jdbc/JdbcSinkConfig.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall LGTM. I left couple of suggestions.
pulsar-io/jdbc/core/src/main/java/org/apache/pulsar/io/jdbc/JdbcSinkConfig.java
Outdated
Show resolved
Hide resolved
pulsar-io/jdbc/core/src/main/java/org/apache/pulsar/io/jdbc/JdbcAbstractSink.java
Outdated
Show resolved
Hide resolved
pulsar-io/jdbc/core/src/main/java/org/apache/pulsar/io/jdbc/JdbcAbstractSink.java
Show resolved
Hide resolved
23231bc
to
9a9e72b
Compare
Codecov Report
@@ Coverage Diff @@
## master #18017 +/- ##
============================================
+ Coverage 34.91% 44.44% +9.52%
- Complexity 5707 16777 +11070
============================================
Files 607 1548 +941
Lines 53396 126139 +72743
Branches 5712 13891 +8179
============================================
+ Hits 18644 56059 +37415
- Misses 32119 64222 +32103
- Partials 2633 5858 +3225
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Motivation
Usually in high load systems the JDBC drivers are meant to be used with the JDBC Batch API. Currently it's not implemented in the jdbc sink
Modifications
useJdbcBatch
to turn on this feature (default to false)executeBatch()
methodsDocumentation
doc
doc-required
doc-not-needed
doc-complete