Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve][pulsar-testclient] Add disableBatching as CLI argument for pulsar-perf-producer #17381

Merged
merged 11 commits into from
Sep 7, 2022

Conversation

vineeth1995
Copy link
Contributor

Motivation

The pulsar-perf-tool should be able to take "disableBatching" as an input argument as it can be provided by the user.

Modifications

Add an extra parameter to in the PerformanceProducer.java class.
Extract producerBuilder creation into a separate method.
Add unit testcase to verify if batching is disabled

Verifying this change

This change added tests and can be verified as follows:

-Added unit test to verify functionality with batching disabled

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API: (no)
  • The schema: (no)
  • The default values of configurations: (no)
  • The wire protocol: (no)
  • The rest endpoints: (no)
  • The admin cli options: (no)
  • Anything that affects deployment: (no)

Documentation

Check the box below or label this PR directly.

Need to update docs?

  • doc-required
    (Your PR needs to update docs and you will update later)

  • doc-not-needed
    (Please explain why)

  • doc
    (Your PR contains doc changes)

  • doc-complete
    (Docs have been already added)

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Aug 31, 2022
@rdhabalia rdhabalia merged commit 5fce0ce into apache:master Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-not-needed Your PR changes do not impact docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants