[fix][broker] Avoid ConcurrentModificationException for ModularLoadManagerImpl.cleanupDeadBrokersData() #16690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nagerImpl.cleanupDeadBrokersData()
codelipenghui
added
type/bug
Technoboy-
approved these changes
Jul 20, 2022
MarvinCai
approved these changes
Jul 20, 2022
HQebupt
approved these changes
Jul 20, 2022
5 tasks
nodece
pushed a commit
to nodece/pulsar
that referenced
this pull request
Jul 23, 2024
…nagerImpl.cleanupDeadBrokersData() (apache#16690) (cherry picked from commit 21a25bf)
nodece
pushed a commit
to ascentstream/pulsar
that referenced
this pull request
Jul 24, 2024
…nagerImpl.cleanupDeadBrokersData() (apache#16690) (cherry picked from commit 21a25bf)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16689
Motivation
Avoid ConcurrentModificationException for ModularLoadManagerImpl.cleanupDeadBrokersData()
The problem was introduced in #14411, so we don't need to cherry-pick to release branches.
Modifications
Make a copy of knownBrokers.
Documentation
Check the box below or label this PR directly.
Need to update docs?
doc-required(Your PR needs to update docs and you will update later)
doc-not-needed(Please explain why)
doc(Your PR contains doc changes)
doc-complete(Docs have been already added)