-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[schema][client][improve] Add decode InputStream for Schema #16659
Conversation
pulsar-client-api/src/main/java/org/apache/pulsar/client/api/Schema.java
Outdated
Show resolved
Hide resolved
pulsar-client-api/src/main/java/org/apache/pulsar/client/api/Schema.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
pulsar-client-api/src/main/java/org/apache/pulsar/common/utils/IOUtils.java
Outdated
Show resolved
Hide resolved
pulsar-broker/src/test/java/org/apache/pulsar/schema/SchemaTest.java
Outdated
Show resolved
Hide resolved
pulsar-client-api/src/main/java/org/apache/pulsar/common/utils/IOUtils.java
Outdated
Show resolved
Hide resolved
pulsar-client/src/main/java/org/apache/pulsar/client/impl/MessageImpl.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tjiuming hi, I don't understand, ByteBufInputStream
has already use the decode(input) why we also need ReadonlyByteBufInputStream
pulsar-client/src/main/java/org/apache/pulsar/client/impl/MessageImpl.java
Outdated
Show resolved
Hide resolved
pulsar-client/src/main/java/org/apache/pulsar/client/impl/MessageImpl.java
Outdated
Show resolved
Hide resolved
pulsar-client-api/src/main/java/org/apache/pulsar/common/utils/IOUtils.java
Outdated
Show resolved
Hide resolved
pulsar-client/src/main/java/org/apache/pulsar/client/util/ReadonlyByteBufInputStream.java
Outdated
Show resolved
Hide resolved
I've discussed with @congbobo184, that introducing decode(InputStream) to Schema may lead to the incorrect usage of users, so decode(ByteBuffer) is enough. |
@congbobo184 PTAL |
@tjiuming Don't run |
/pulsarbot run-failure-checks |
Motivation
Add decode(InputStream) for Schema, for the purpose of preventing allocate heap memory directly.
Modifications
Does this pull request potentially affect one of the following parts:
If
yes
was chosen, please highlight the changesDocumentation
Check the box below or label this PR directly.
Need to update docs?
doc-required
(Your PR needs to update docs and you will update later)
doc-not-needed
(Please explain why)
doc
(Your PR contains doc changes)
doc-complete
(Docs have been already added)