[improve][broker] Make some method on permission async #16324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
26 tasks
gaozhangmin
requested review from
codelipenghui,
mattisonchao,
nodece and
Technoboy-
gaozhangmin
added
area/admin
type/enhancement
Technoboy-
reviewed
Jul 4, 2022
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/NamespacesBase.java
Outdated
Show resolved
Hide resolved
Technoboy-
approved these changes
Jul 8, 2022
merlimat
approved these changes
Jul 12, 2022
wuxuanqicn
pushed a commit
to wuxuanqicn/pulsar
that referenced
this pull request
Jul 14, 2022
Co-authored-by: gavingaozhangmin <gavingaozhangmin@didiglobal.com>
26 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
See PIP #14365 and change tracker #15043.
Make the below method async:
getPermissionOnSubscriptiongrantPermissionOnNamespacegrantPermissionOnSubscriptionrevokePermissionsOnNamespacerevokePermissionOnSubscriptionDocumentation
Check the box below or label this PR directly.
Need to update docs?
doc-not-needed