[improve][client] Add classLoader field for SchemaDefinition
#15915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er().withJsonDef()`
codelipenghui
approved these changes
Jun 6, 2022
codelipenghui
added
release/2.9.3
release/2.10.1
type/bug
mattisonchao
approved these changes
Jun 8, 2022
|
/pulsarbot run-failure-checks |
1 similar comment
|
/pulsarbot run-failure-checks |
|
Hi @coderzc We re-run the test many times, but the test still fails. Could you take a look? |
ok |
|
/pulsarbot run-failure-checks |
|
/pulsarbot run-failure-checks |
coderzc
force-pushed
the
fix_issuse_15899
branch
2 times, most recently
from
b42e1db to
b0dac72
Compare
coderzc
force-pushed
the
fix_issuse_15899
branch
from
b0dac72 to
36b723c
Compare
coderzc
changed the title
SchemaDefinition.<T>builder().withJsonDef()SchemaDefinition
coderzc
force-pushed
the
fix_issuse_15899
branch
from
f112576 to
7325c67
Compare
codelipenghui
requested changes
Jun 12, 2022
| * | ||
| * @return schema definition builder | ||
| */ | ||
| SchemaDefinitionBuilder<T> withClassLoader(ClassLoader classLoader); |
There was a problem hiding this comment.
If need to add a public API to fix the issue, it should start with a proposal first.
There was a problem hiding this comment.
OK, I have been submitted a PIP: #16058
codelipenghui
approved these changes
Jun 22, 2022
congbobo184
approved these changes
Jun 23, 2022
coderzc
changed the title
SchemaDefinitionSchemaDefinition
coderzc
changed the title
SchemaDefinitionSchemaDefinition
codelipenghui
pushed a commit
that referenced
this pull request
Jun 28, 2022
Fixes #15899 ### Motivation Now, don‘t register logical type conversions when use `SchemaDefinition.<T>builder().withJsonDef()` beacase it without classLoader param. See: https://github.com/apache/pulsar/blob/04aa9e8e51869d1621a7e25402a656084eebfc09/pulsar-client/src/main/java/org/apache/pulsar/client/impl/schema/reader/AvroReader.java#L58-L68 We can add the classLoader field for `SchemaDefinition`, user can manually pass a classLoader to register logical type conversions ### Modifications Add classLoader field for `SchemaDefinition` (cherry picked from commit 8434500)
mattisonchao
pushed a commit
that referenced
this pull request
Jul 2, 2022
Fixes #15899 ### Motivation Now, don‘t register logical type conversions when use `SchemaDefinition.<T>builder().withJsonDef()` beacase it without classLoader param. See: https://github.com/apache/pulsar/blob/04aa9e8e51869d1621a7e25402a656084eebfc09/pulsar-client/src/main/java/org/apache/pulsar/client/impl/schema/reader/AvroReader.java#L58-L68 We can add the classLoader field for `SchemaDefinition`, user can manually pass a classLoader to register logical type conversions ### Modifications Add classLoader field for `SchemaDefinition` (cherry picked from commit 8434500)
nicoloboschi
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jul 4, 2022
) Fixes apache#15899 ### Motivation Now, don‘t register logical type conversions when use `SchemaDefinition.<T>builder().withJsonDef()` beacase it without classLoader param. See: https://github.com/apache/pulsar/blob/04aa9e8e51869d1621a7e25402a656084eebfc09/pulsar-client/src/main/java/org/apache/pulsar/client/impl/schema/reader/AvroReader.java#L58-L68 We can add the classLoader field for `SchemaDefinition`, user can manually pass a classLoader to register logical type conversions ### Modifications Add classLoader field for `SchemaDefinition` (cherry picked from commit 8434500) (cherry picked from commit ea20a89)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15899
Motivation
Now, don‘t register logical type conversions when use
SchemaDefinition.<T>builder().withJsonDef()beacase it without classLoader param.See:
pulsar/pulsar-client/src/main/java/org/apache/pulsar/client/impl/schema/reader/AvroReader.java
Lines 58 to 68 in 04aa9e8
We can add the classLoader field for
SchemaDefinition, user can manually pass a classLoader to register logical type conversionsModifications
Add classLoader field for
SchemaDefinitionVerifying this change
(Please pick either of the following options)
This change added tests and can be verified
Documentation
Check the box below or label this PR directly.
Need to update docs?
doc-required(Your PR needs to update docs and you will update later)
doc-not-needed(Please explain why)
doc(Your PR contains doc changes)
doc-complete(Docs have been already added)