Added Kafka Source and Kafka Sink to Pulsar Connect #1557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sijie
reviewed
Apr 12, 2018
pom.xml
Outdated
| @@ -144,6 +144,7 @@ flexible messaging model and an intuitive client API.</description> | |||
| <hbc-core.version>2.2.0</hbc-core.version> | |||
| <cassandra-driver-core.version>3.4.0</cassandra-driver-core.version> | |||
| <aerospike-client.version>4.1.5</aerospike-client.version> | |||
| <kafka-client.version>0.10.0.0</kafka-client.version> | |||
There was a problem hiding this comment.
1.0 seems a very recent release. Used 0.10 since that seems to be the most popular version out there. I'm assuming that most of the migrations will come from ppl running kafka for a while.
There was a problem hiding this comment.
There's already a version of kafka clients used for the wrapper. We should probably standardize on one version
sijie
approved these changes
Apr 12, 2018
|
@merlimat I've standardized the versions used by both modules. Please take a look again. Thanks! |
|
retest this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Explain here the context, and why you're making that change.
What is the problem you're trying to solve.
Modifications
Describe the modifications you've done.
Result
After your change, what will change.