[Fix][Txn] Fix transaction PendingAck lowWaterMark #15530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Motivation Now, PendingAckHandle use the ending transaction ID to append abort mark, but it is wrong. We should append abort mark for the first transaction in the individualAckOfTransaction after judgment. ### Modification Append abort mark for the first transaction in the individualAckOfTransaction after judgment.
codelipenghui
approved these changes
May 12, 2022
codelipenghui
added
type/bug
|
/pulsarbot run-failure-checks |
congbobo184
approved these changes
May 13, 2022
congbobo184
pushed a commit
that referenced
this pull request
May 19, 2022
### Motivation Now, PendingAckHandle use the ending transaction ID to append abort mark, but it is wrong. We should append abort mark for the first transaction in the individualAckOfTransaction after judgment. ### Modification Append abort mark for the first transaction in the individualAckOfTransaction after judgment. (cherry picked from commit 498cde9)
congbobo184
pushed a commit
that referenced
this pull request
May 19, 2022
congbobo184
pushed a commit
that referenced
this pull request
May 19, 2022
### Motivation Now, PendingAckHandle use the ending transaction ID to append abort mark, but it is wrong. We should append abort mark for the first transaction in the individualAckOfTransaction after judgment. ### Modification Append abort mark for the first transaction in the individualAckOfTransaction after judgment. (cherry picked from commit 498cde9)
nicoloboschi
pushed a commit
to datastax/pulsar
that referenced
this pull request
May 19, 2022
### Motivation Now, PendingAckHandle use the ending transaction ID to append abort mark, but it is wrong. We should append abort mark for the first transaction in the individualAckOfTransaction after judgment. ### Modification Append abort mark for the first transaction in the individualAckOfTransaction after judgment. (cherry picked from commit 498cde9) (cherry picked from commit 58bd9bc)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Now, PendingAckHandle use the ending transaction ID to append abort mark, but it is wrong. We should append abort mark for the first transaction in the individualAckOfTransaction after judgment.
Modification
Append abort mark for the first transaction in the individualAckOfTransaction after judgment.
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation
Check the box below or label this PR directly.
Need to update docs?
doc-required(Your PR needs to update docs and you will update later)
no-need-doc(Please explain why)
doc(Your PR contains doc changes)
doc-added(Docs have been already added)