[cleanup][broker] PIP 45: Deprecate zookeeper settings managedLedgerMaxUnackedRangesToPersistInZooKeeper #15099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
doc-required
HQebupt
approved these changes
Apr 10, 2022
Jason918
reviewed
Apr 10, 2022
Fixed, thanks to you. |
|
@momo-jun a soft reminder: here is a PR w/ doc-required label, could u pls follow up? Thanks |
Jason918
reviewed
Apr 11, 2022
1 task
In case this PR (for ZK free) is merged into 2.10, I drafted a related doc PR to catch up. |
Anonymitaet
added
doc-complete
nodece
approved these changes
Apr 12, 2022
conf/broker.conf
Outdated
| # than this limit then broker will persist unacked ranges into bookkeeper to avoid additional data overhead into | ||
| # zookeeper. | ||
| # Deprecated: use managedLedgerMaxUnackedRangesToPersistInMetadataStore | ||
| managedLedgerMaxUnackedRangesToPersistInZooKeeper=1000 |
There was a problem hiding this comment.
You can change the default value of the deprecated to -1
and then check if users changed -1 to other values, we should apply this one.
|
/pulsarbot rerun-failure-checks |
codelipenghui
approved these changes
Apr 15, 2022
codelipenghui
changed the title
aparajita89
pushed a commit
to aparajita89/pulsar
that referenced
this pull request
Apr 18, 2022
…axUnackedRangesToPersistInZooKeeper (apache#15099)
Nicklee007
pushed a commit
to Nicklee007/pulsar
that referenced
this pull request
Apr 20, 2022
…axUnackedRangesToPersistInZooKeeper (apache#15099)
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
To deprecate the zookeeper settings. PIP 45 introduced a unified metadata store API for Pulsar,
so we should make the metadata-related configuration start with
metadataStore, notzooKeeper/ZK.Modifications
managedLedgerMaxUnackedRangesToPersistInZooKeepertomanagedLedgerMaxUnackedRangesToPersistInMetadataStoremaxUnackedRangesToPersistInZktomaxUnackedRangesToPersistInMetadataStore.Verifying this change
Does this pull request potentially affect one of the following parts:
Documentation
doc-required(Your PR needs to update docs and you will update later)
Compatibility
Introduce
getManagedLedgerMaxUnackedRangesToPersistInMetadataStoremethod to compatible with previous configurations.