Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Change the required checks to match refactored Pulsar CI #14944

Merged
merged 1 commit into from
Mar 30, 2022

Conversation

lhotari
Copy link
Member

@lhotari lhotari commented Mar 30, 2022

Motivation

Additional context:

Modifications

  • rename CI - Integration - Function to CI - System - Function and
    CI - Integration - Schema to CI - System - Schema

  • remove Sql integration tests ("CI - System - Sql") from required checks

@lhotari lhotari added doc-not-needed Your PR changes do not impact docs area/ci labels Mar 30, 2022
@lhotari lhotari self-assigned this Mar 30, 2022
@lhotari lhotari marked this pull request as draft March 30, 2022 09:18
@lhotari
Copy link
Member Author

lhotari commented Mar 30, 2022

Since the required checks have already been changed, it's not possible to revert the changes in .asf.yaml or modify it before #14819 is in use. I have made a workaround in #14819 to make the current required checks to pass and I'll remove the workaround in this PR after #14819 has been merged. That's why I made this PR a draft.

@lhotari lhotari force-pushed the lh-revisit-required-checks branch from c2fc9e4 to 4fb17ac Compare March 30, 2022 16:20
@lhotari lhotari marked this pull request as ready for review March 30, 2022 16:22
@lhotari lhotari requested review from dave2wave, dlg99 and merlimat March 30, 2022 16:26
Copy link
Member

@michaeljmarshall michaeljmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lhotari
Copy link
Member Author

lhotari commented Mar 30, 2022

/pulsarbot rerun-failure-checks

- Python client is required for Functions and Schema tests and
  tests were needed to move to a different category

- Sql integration tests ("CI - System - Sql") are disabled until
  apache#14951 has been resolved
@lhotari lhotari force-pushed the lh-revisit-required-checks branch from 4fb17ac to daa105c Compare March 30, 2022 18:53
@lhotari
Copy link
Member Author

lhotari commented Mar 30, 2022

Removing the workaround must happen in a separate PR after .asf.yaml has been update with this PR.

@lhotari lhotari merged commit 902ed07 into apache:master Mar 30, 2022
Nicklee007 pushed a commit to Nicklee007/pulsar that referenced this pull request Apr 20, 2022
- Python client is required for Functions and Schema tests and
  tests were needed to move to a different category

- Sql integration tests ("CI - System - Sql") are disabled until
  apache#14951 has been resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci doc-not-needed Your PR changes do not impact docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants