Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Flaky-test: SubscriptionSeekTest.testShouldCloseAllConsumersForMultipleConsumerDispatcherWhenSeek #14674

Merged
merged 2 commits into from
Mar 16, 2022

Conversation

shibd
Copy link
Member

@shibd shibd commented Mar 14, 2022

Motivation

#11703

When conumser1 call seek, need wait for conumser2 also reconnect success, then assert.

Modifications

  • add wait for conumser2 reconnect.

Documentation

  • no-need-doc

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Mar 14, 2022
Copy link
Member

@RobertIndie RobertIndie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shibd
Copy link
Member Author

shibd commented Mar 14, 2022

/pulsarbot run-failure-checks

@codelipenghui codelipenghui changed the title fix flaky-test: SubscriptionSeekTest.testShouldCloseAllConsumersForMu… Fix Flaky-test: SubscriptionSeekTest.testShouldCloseAllConsumersForMultipleConsumerDispatcherWhenSeek Mar 16, 2022
@codelipenghui codelipenghui merged commit 157b808 into apache:master Mar 16, 2022
@shibd shibd deleted the feat-11703 branch March 16, 2022 11:21
codelipenghui pushed a commit that referenced this pull request Mar 18, 2022
…leConsumerDispatcherWhenSeek (#14674)

(cherry picked from commit 157b808)
@codelipenghui codelipenghui added the cherry-picked/branch-2.9 Archived: 2.9 is end of life label Mar 18, 2022
aparajita89 pushed a commit to aparajita89/pulsar that referenced this pull request Mar 21, 2022
codelipenghui pushed a commit that referenced this pull request Apr 19, 2022
…leConsumerDispatcherWhenSeek (#14674)

(cherry picked from commit 157b808)
Nicklee007 pushed a commit to Nicklee007/pulsar that referenced this pull request Apr 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants