Fix PartitionedProducerImpl flushAsync always fail when one partition send TimeOutException #14602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… send TimeOutException
lhotari
requested changes
Mar 8, 2022
pulsar-client/src/main/java/org/apache/pulsar/client/impl/ProducerImpl.java
Outdated
Show resolved
Hide resolved
pulsar-client/src/main/java/org/apache/pulsar/client/impl/ProducerImpl.java
Outdated
Show resolved
Hide resolved
pulsar-client/src/main/java/org/apache/pulsar/client/impl/ProducerImpl.java
Outdated
Show resolved
Hide resolved
pulsar-client/src/main/java/org/apache/pulsar/client/impl/ProducerImpl.java
Outdated
Show resolved
Hide resolved
pulsar-client/src/test/java/org/apache/pulsar/client/impl/PartitionedProducerImplTest.java
Outdated
Show resolved
Hide resolved
lhotari
reviewed
Mar 9, 2022
pulsar-client/src/main/java/org/apache/pulsar/client/impl/ProducerImpl.java
Outdated
Show resolved
Hide resolved
pulsar-client/src/main/java/org/apache/pulsar/client/impl/ProducerImpl.java
Outdated
Show resolved
Hide resolved
pulsar-client/src/test/java/org/apache/pulsar/client/impl/PartitionedProducerImplTest.java
Outdated
Show resolved
Hide resolved
eolivelli
reviewed
Mar 9, 2022
pulsar-client/src/test/java/org/apache/pulsar/client/impl/PartitionedProducerImplTest.java
Outdated
Show resolved
Hide resolved
|
@lhotari @michaeljmarshall @eolivelli Thanks much for your review and help. I add a test |
|
/pulsarbot run-failure-checks |
1 task
lhotari
requested changes
Mar 9, 2022
pulsar-broker/src/test/java/org/apache/pulsar/client/api/SimpleProducerConsumerTest.java
Outdated
Show resolved
Hide resolved
lhotari
requested changes
Mar 9, 2022
pulsar-client/src/main/java/org/apache/pulsar/client/impl/ProducerImpl.java
Show resolved
Hide resolved
lhotari
approved these changes
Mar 10, 2022
There was a problem hiding this comment.
LGTM. Good work @wenbingshen. Thank you for the contribution.
@lhotari Thanks for your review and great comments. :) |
pulsar-client/src/main/java/org/apache/pulsar/client/impl/ProducerImpl.java
Show resolved
Hide resolved
pulsar-client/src/main/java/org/apache/pulsar/client/impl/ProducerImpl.java
Show resolved
Hide resolved
pulsar-client-api/src/main/java/org/apache/pulsar/client/api/Producer.java
Outdated
Show resolved
Hide resolved
pulsar-client/src/main/java/org/apache/pulsar/client/impl/ProducerImpl.java
Outdated
Show resolved
Hide resolved
pulsar-broker/src/test/java/org/apache/pulsar/client/api/SimpleProducerConsumerTest.java
Show resolved
Hide resolved
pulsar-broker/src/test/java/org/apache/pulsar/client/api/SimpleProducerConsumerTest.java
Show resolved
Hide resolved
|
/pulsarbot run-failure-checks |
codelipenghui
approved these changes
Mar 15, 2022
congbobo184
approved these changes
Mar 15, 2022
codelipenghui
pushed a commit
that referenced
this pull request
Mar 18, 2022
… send TimeOutException (#14602) Fixes #14598 Master Issue: #14598 Detailed issue description can be found at #14598 After the `lastSendFuture` returned to application from in `org.apache.pulsar.client.impl.ProducerImpl#flushAsync` acquired , it should not continue to be thrown to the application, the `lastSendFuture` whether an exception occurs or completed, and the application is only allowed to acquire it once, otherwise it will cause `org. apache.pulsar.client.impl.PartitionedProducerImpl#flushAsync ` cannot continue to send data until data is sent again to the abnormal `ProducerImpl`. (cherry picked from commit ddca852)
codelipenghui
pushed a commit
that referenced
this pull request
Mar 19, 2022
… send TimeOutException (#14602) Fixes #14598 Master Issue: #14598 ### Motivation Detailed issue description can be found at #14598 ### Modifications After the `lastSendFuture` returned to application from in `org.apache.pulsar.client.impl.ProducerImpl#flushAsync` acquired , it should not continue to be thrown to the application, the `lastSendFuture` whether an exception occurs or completed, and the application is only allowed to acquire it once, otherwise it will cause `org. apache.pulsar.client.impl.PartitionedProducerImpl#flushAsync ` cannot continue to send data until data is sent again to the abnormal `ProducerImpl`. (cherry picked from commit ddca852)
Nicklee007
pushed a commit
to Nicklee007/pulsar
that referenced
this pull request
Apr 20, 2022
… send TimeOutException (apache#14602) Fixes apache#14598 Master Issue: apache#14598 ### Motivation Detailed issue description can be found at apache#14598 ### Modifications After the `lastSendFuture` returned to application from in `org.apache.pulsar.client.impl.ProducerImpl#flushAsync` acquired , it should not continue to be thrown to the application, the `lastSendFuture` whether an exception occurs or completed, and the application is only allowed to acquire it once, otherwise it will cause `org. apache.pulsar.client.impl.PartitionedProducerImpl#flushAsync ` cannot continue to send data until data is sent again to the abnormal `ProducerImpl`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14598
Master Issue: #14598
Motivation
Detailed issue description can be found at #14598
Modifications
After the
lastSendFuturereturned to application from inorg.apache.pulsar.client.impl.ProducerImpl#flushAsyncacquired , it should not continue to be thrown to the application, thelastSendFuturewhether an exception occurs or completed, and the application is only allowed to acquire it once, otherwise it will causeorg. apache.pulsar.client.impl.PartitionedProducerImpl#flushAsynccannot continue to send data until data is sent again to the abnormalProducerImpl.Documentation
Check the box below or label this PR directly (if you have committer privilege).
Need to update docs?
no-need-doc