Send Log statements to log Topic for Java Functions #1447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
retest this please |
sijie
reviewed
Mar 27, 2018
| @@ -262,10 +268,12 @@ public void run() { | |||
| } | |||
| long processAt = System.currentTimeMillis(); | |||
| stats.incrementProcessed(processAt); | |||
| addLogTopicHandler(); | |||
There was a problem hiding this comment.
this seems to be done at per message?
Can we configure the log handler at the beginning of the instance and remove it at the end?
There was a problem hiding this comment.
We need to send only the log messages inside the function to the log topic. Other logging messages inside the java instance or runtime should not be sent. Thats why we need to do this on a per message basis.
There was a problem hiding this comment.
okay... I am not sure if there is any performance penalty here. but okay to me for now.
sijie
approved these changes
Mar 27, 2018
sijie
approved these changes
Mar 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently logTopic directive only works for Python functions. This pr brings that functionality to Java Functions as well.
Modifications
Describe the modifications you've done.
Result
After your change, what will change.