Add threshold for each unload round for uniform load shedder #13915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hangc0276
requested review from
rdhabalia,
315157973,
codelipenghui,
gaoran10,
Jason918,
hezhangjian and
zymap
github-actions
bot
added
the
doc-required
hangc0276
added
area/broker
doc-required
codelipenghui
approved these changes
Jan 24, 2022
mattisonchao
approved these changes
Jan 24, 2022
hangc0276
force-pushed
the
chenhang/reduce_unload_percentage_for_UniformLoadShedder
branch
from
f70731b to
b001103
Compare
@mattisonchao Thanks for your review. The feature was added in pulsar 2.10.0, and we will add doc to explain the unload strategy. For the default values, in most of cases, we don't need to change it, so we can make them default first aiming to make |
I see. |
Anonymitaet
added
doc-complete
Nicklee007
pushed a commit
to Nicklee007/pulsar
that referenced
this pull request
Apr 20, 2022
…13915) ### Motivation For current uniform load shedder, it will unload 50% of (max throughput - min throughput) or (max message rate - min message rate). If the max throughput is 500MB/s, and the min throughput is 0MB/s, it will unload 250MB/s throughput at a time, which will lead the broker into high load for unloading a lot of bundles and cause the broker unstable. Another problem is that the current implementation has no min unload threshold limit. For example, if the max broker throughput is 1MB/s and the min broker throughput is 0MB/s, it will unload 0.5MB/s throughput from the max throughput broker, which is unnecessary and will cause bundle frequently unload. ### Modification Change the default unload percentage from 50% to 20%, aiming to make the unload process smooth. Add MIN_UNLOAD_MESSAGE=1000 and MIN_UNLOAD_THROUGHPUT=1 * MB, which will skip the low throughput bundle unload and decrease the bundle unload frequency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
For current uniform load shedder, it will unload 50% of
(max throughput - min throughput)or (max message rate - min message rate). If the max throughput is 500MB/s, and the min throughput is 0MB/s, it will unload 250MB/s throughput at a time, which will lead the broker into high load for unloading a lot of bundles and cause the broker unstable.Another problem is that the current implementation has no min unload threshold limit. For example, if the max broker throughput is 1MB/s and the min broker throughput is 0MB/s, it will unload 0.5MB/s throughput from the max throughput broker, which is unnecessary and will cause bundle frequently unload.
Modification
MIN_UNLOAD_MESSAGE=1000andMIN_UNLOAD_THROUGHPUT=1 * MB, which will skip the low throughput bundle unload and decrease the bundle unload frequency.Documentation
Check the box below or label this PR directly (if you have committer privilege).
Need to update docs?
doc-required(If you need help on updating docs, create a doc issue)
no-need-doc(Please explain why)
doc(If this PR contains doc changes)