Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release old bundle from ownership cache when operator split bundle #13678

Merged
merged 3 commits into from
Jan 18, 2022
Merged

release old bundle from ownership cache when operator split bundle #13678

merged 3 commits into from
Jan 18, 2022

Conversation

Nicklee007
Copy link
Contributor

@Nicklee007 Nicklee007 commented Jan 8, 2022 •
edited
Loading

Fixes #13677

Modifications

release the old bundle from ownership and temporary znode cache when we split the old bundle;

Modifications

remove the old bundle when we split the bundle successed, and async release the temporary znode

Documentation

Check the box below and label this PR (if you have committer privilege).
Need to update docs?

  • no-need-doc

@github-actions
Copy link

github-actions bot commented Jan 8, 2022

@Nicklee007:Thanks for your contribution. For this PR, do we need to update docs?
(The PR template contains info about doc, which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)

@hezhangjian
Copy link
Member

@Nicklee007 Could you please add unit tests for this case ? :)

@Anonymitaet
Copy link
Member

@Nicklee007

You delete the backticks (``) so that Bot can not recognize the info and then labels the PR with doc-info-missing.
[x] `doc-required` ✅
[x] doc-required ❌

Instructions of doc labels: https://docs.google.com/document/d/1Qw7LHQdXWBW9t2-r-A7QdFDBwmZh6ytB4guwMoXHqc0/edit#bookmark=id.5d66olk7l4oz

@Anonymitaet Anonymitaet added doc-not-needed Your PR changes do not impact docs and removed doc-label-missing labels Jan 10, 2022
@Nicklee007
Copy link
Contributor Author

@Shoothzj ok, I have add unit test for the case.

hezhangjian
hezhangjian reviewed Jan 11, 2022
View reviewed changes
pulsar-broker/src/test/java/org/apache/pulsar/broker/namespace/NamespaceServiceTest.java Outdated
}
Awaitility.await().untilAsserted(()
-> assertNull(namespaceService.getOwnershipCache().getOwnedBundles().get(splitBundle2)));

Copy link
Member

@hezhangjian hezhangjian Jan 11, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unneeded space line

hezhangjian
hezhangjian reviewed Jan 11, 2022
View reviewed changes
pulsar-broker/src/test/java/org/apache/pulsar/broker/namespace/NamespaceServiceTest.java Outdated
TopicName topicName = TopicName.get("persistent://pulsar/global/ns1/topic-1");
NamespaceBundles bundles = namespaceService.getNamespaceBundleFactory().getBundles(nsname);


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest one space line instead of two

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest one space line instead of two

@Shoothzj Thank you for your correction，update it yet.

@codelipenghui codelipenghui added this to the 2.10.0 milestone Jan 12, 2022
@codelipenghui codelipenghui added release/2.9.2 type/bug The PR fixed a bug or issue reported a bug labels Jan 12, 2022
codelipenghui
codelipenghui approved these changes Jan 12, 2022
View reviewed changes
Copy link
Contributor

@codelipenghui codelipenghui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@codelipenghui codelipenghui merged commit 0cd9462 into apache:master Jan 18, 2022
codelipenghui pushed a commit that referenced this pull request Jan 18, 2022
@Nicklee007 @codelipenghui
Release old bundle from ownership cache when operator split bundle (#…
0bfd38e 
…13678)

Fixes #13677

 Modifications

release the old bundle from ownership and temporary znode cache when we split the old bundle;

(cherry picked from commit 0cd9462)
@codelipenghui codelipenghui added the cherry-picked/branch-2.9 Archived: 2.9 is end of life label Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaozhangmin gaozhangmin gaozhangmin approved these changes

@315157973 315157973 315157973 approved these changes

@codelipenghui codelipenghui codelipenghui approved these changes

@gaoran10 gaoran10 gaoran10 approved these changes

@hezhangjian hezhangjian Awaiting requested review from hezhangjian

@merlimat merlimat Awaiting requested review from merlimat

@hangc0276 hangc0276 Awaiting requested review from hangc0276

Assignees

@Nicklee007 Nicklee007

Labels
area/broker cherry-picked/branch-2.9 Archived: 2.9 is end of life doc-not-needed Your PR changes do not impact docs release/2.9.2 type/bug The PR fixed a bug or issue reported a bug
Projects
None yet
Milestone
2.10.0
Development

Successfully merging this pull request may close these issues.

when a bundle split, the old bundle is not release from ownership cache
7 participants
@Nicklee007 @hezhangjian @Anonymitaet @gaozhangmin @315157973 @codelipenghui @gaoran10