Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OF: t2.small ec2 instances are not available in us-west-2d #13674

Merged
merged 1 commit into from
Jan 11, 2022

Conversation

dave2wave
Copy link
Member

@dave2wave dave2wave commented Jan 7, 2022

Motivation

During benchmark testing of Pulsar with openmessaging/benchmark I noticed that t2.small ec2 instances are not available in us-west-2d.

Modifications

Changed t2.small to t3.small in three places in two files.

Verifying this change

  • Make sure that the change passes the CI checks.

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Anything that affects deployment: (yes)

Documentation

  • doc

@github-actions github-actions bot added the doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. label Jan 7, 2022
@Anonymitaet
Copy link
Member

Hi @nodece can you review this PR from the technical perspective? Thanks

@nodece
Copy link
Member

nodece commented Jan 11, 2022

@dave2wave Thanks for your contribution!

Copy link
Member

@nodece nodece left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nodece
Copy link
Member

nodece commented Jan 11, 2022

@Anonymitaet This PR can be merged.

@Anonymitaet Anonymitaet added this to the 2.10.0 milestone Jan 11, 2022
@Anonymitaet Anonymitaet merged commit 00bfc07 into master Jan 11, 2022
liudezhi2098 pushed a commit to liudezhi2098/pulsar that referenced this pull request Jan 11, 2022
@codelipenghui codelipenghui deleted the dave2wave-t3-small branch February 16, 2022 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Your PR contains doc changes, no matter whether the changes are in markdown or code files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants