Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Docs] Added information to help users resolve IntelliJ issues. #13673

Merged
merged 5 commits into from
Jan 11, 2022
Merged

[Docs] Added information to help users resolve IntelliJ issues. #13673

merged 5 commits into from
Jan 11, 2022

Conversation

devinbost
Copy link
Contributor

@devinbost devinbost commented Jan 7, 2022 •
edited
Loading

I added some instructions to help developers resolve issues in IntelliJ that may occur when trying to run Pulsar unit tests.

  • doc

@github-actions
Copy link

github-actions bot commented Jan 7, 2022

@devinbost:Thanks for your contribution. For this PR, do we need to update docs?
(The PR template contains info about doc, which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)

nicoloboschi
nicoloboschi requested changes Jan 7, 2022
View reviewed changes
README.md Outdated
* Run `mvn clean install -DskipTests` on the command line
* Reopen IntelliJ
* If that still doesn't work:
* Verify maven is using a supported version. Currently, the supported version of Maven is 3.6.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should be consistent with the maven enforcer plugin configuration

pulsar/pom.xml

Lines 1650 to 1652 in bacac04

<requireMavenVersion>
<version>[3.3.9,)</version>
</requireMavenVersion>

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, we're requiring users to be running Maven 3.3.9?

@Anonymitaet
Copy link
Member

@devinbost when submitting a PR, can you provide doc-related info (tick the box) in the PR description? So that Bot can recognize and label your PR correspondingly. Or else Bot labels your PR with doc-info-missing.

Instructions of doc labels: https://docs.google.com/document/d/1Qw7LHQdXWBW9t2-r-A7QdFDBwmZh6ytB4guwMoXHqc0/edit#bookmark=id.5d66olk7l4oz

image

@Anonymitaet Anonymitaet added doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. and removed doc-label-missing labels Jan 10, 2022
Anonymitaet
Anonymitaet reviewed Jan 10, 2022
View reviewed changes
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@Anonymitaet Anonymitaet added this to the 2.10.0 milestone Jan 10, 2022
devinbost and others added 4 commits January 10, 2022 10:57
@devinbost @Anonymitaet
Changed unordered to ordered sequence
c014907 
Co-authored-by: Anonymitaet <50226895+Anonymitaet@users.noreply.github.com>
@devinbost @Anonymitaet
Capitalization of nouns
561544c 
Co-authored-by: Anonymitaet <50226895+Anonymitaet@users.noreply.github.com>
@devinbost @Anonymitaet
Changing to numbered sequence
4ad8cc5 
Co-authored-by: Anonymitaet <50226895+Anonymitaet@users.noreply.github.com>
Clarified Maven version
dc848d8
@devinbost devinbost requested a review from Anonymitaet January 10, 2022 18:03
@Anonymitaet Anonymitaet merged commit 530c6cd into apache:master Jan 11, 2022
liudezhi2098 pushed a commit to liudezhi2098/pulsar that referenced this pull request Jan 11, 2022
@devinbost @liudezhi2098
[Docs] Added information to help users resolve IntelliJ issues. (apac…
e533b39 
…he#13673)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Anonymitaet Anonymitaet Anonymitaet approved these changes

@nicoloboschi nicoloboschi nicoloboschi approved these changes

@hezhangjian hezhangjian hezhangjian approved these changes

Assignees

@devinbost devinbost

Labels
doc Your PR contains doc changes, no matter whether the changes are in markdown or code files.
Projects
None yet
Milestone
2.10.0
Development

Successfully merging this pull request may close these issues.
4 participants
@devinbost @Anonymitaet @hezhangjian @nicoloboschi