Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply modernizer plugin to pulsar-client-autn pulsar-websocket and pu… #13398

Merged
merged 1 commit into from
Dec 21, 2021

Conversation

MarvinCai
Copy link
Contributor

Master Issue: #12271

Motivation

Apply Maven Modernizer plugin to enforce we move away from legacy APIs for pulsar-client-auth pulsar-websocket and pulsar-broker-auth modules.

Modifications

Add Maven Modernizer plugin in pom and fix violation.

Verifying this change

This change is already covered by existing tests, such as (please describe tests).

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API: (no)
  • The schema: (no)
  • The default values of configurations: (no)
  • The wire protocol: (no)
  • The rest endpoints: (no)
  • The admin cli options: (no)
  • Anything that affects deployment: (no)

Documentation

Check the box below and label this PR (if you have committer privilege).

Need to update docs?

  • doc-required

    (If you need help on updating docs, create a doc issue)

  • no-need-doc

    (Please explain why)

  • doc

    (If this PR contains doc changes)

@MarvinCai MarvinCai requested a review from lhotari December 20, 2021 01:27
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Dec 20, 2021
@codelipenghui codelipenghui added this to the 2.10.0 milestone Dec 20, 2021
Copy link
Member

@lhotari lhotari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codelipenghui codelipenghui merged commit 383c1ee into apache:master Dec 21, 2021
Copy link
Member

@michaeljmarshall michaeljmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late review. I am +1 on this. LGTM.

Technoboy- pushed a commit to Technoboy-/pulsar that referenced this pull request Dec 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-not-needed Your PR changes do not impact docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants