Remove unused assign value in DefaultMessageFormatter #12837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/pulsarbot run-failure-checks |
Jason918
reviewed
Nov 17, 2021
pulsar-testclient/src/main/java/org/apache/pulsar/testclient/DefaultMessageFormatter.java
Show resolved
Hide resolved
pulsar-testclient/src/main/java/org/apache/pulsar/testclient/DefaultMessageFormatter.java
Outdated
Show resolved
Hide resolved
|
@Shoothzj Please check the comments |
hezhangjian
changed the title
|
@codelipenghui @Jason918 Please take a view again |
codelipenghui
approved these changes
Dec 2, 2021
|
@Jason918 @RobertIndie Please help review this PR. |
RobertIndie
approved these changes
Dec 2, 2021
Jason918
approved these changes
Dec 2, 2021
hezhangjian
deleted the
remove-werid-assign-value-in-DefaultMessageFromatter
branch
fxbing
pushed a commit
to fxbing/pulsar
that referenced
this pull request
Dec 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifications
Remove werid assign value in DefaultMessageFormatter
Documentation
Check the box below and label this PR (if you have committer privilege).
Need to update docs?
no-need-docsimple optimize