[testclient] Replace '--auth_plugin' with '--auth-plugin' #12263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuruguo
changed the title
eolivelli
requested changes
Oct 4, 2021
| @@ -95,7 +95,10 @@ | |||
| @Parameter(names = { "-t", "--num-topic" }, description = "Number of topics", validateWith = PositiveNumberParameterValidator.class) | |||
| public int numTopics = 1; | |||
|
|
|||
| @Parameter(names = { "--auth_plugin" }, description = "Authentication plugin class name") | |||
| @Parameter(names = { "--auth_plugin" }, description = "Authentication plugin class name", hidden = true) | |||
| public String DEPRECATED_authPluginClassName; | |||
There was a problem hiding this comment.
This is bad name for a Java field.
Please use Camel case
eolivelli
approved these changes
Oct 5, 2021
315157973
approved these changes
Oct 6, 2021
tuteng
approved these changes
Oct 11, 2021
hangc0276
approved these changes
Oct 12, 2021
bharanic-dev
pushed a commit
to bharanic-dev/pulsar
that referenced
this pull request
Mar 18, 2022
### Motivation The name of the option should be linked with a horizontal line(-) instead of an underline(_) in CLI, so that it conforms to the unified standard. Therefore, option --auth_plugin should be deprecated and replaced with --auth-plugin. ### Modifications Hidden --auth_plugin --auth_plug takes effect when --auth-plugin is blank and --auth_plugin is not blank
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The name of the option should be linked with a horizontal line(-) instead of an underline(_) in
CLI, so that it conforms to the unified standard.Therefore, option
--auth_pluginshould be deprecated and replaced with--auth-plugin.Modifications
--auth_plugin--auth_plugtakes effect when--auth-pluginis blank and--auth_pluginis not blankDocumentation