[testclient] Add new option --num-messages for consumer and reader #12016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaoran10
reviewed
Sep 12, 2021
| @@ -293,6 +297,11 @@ public static void main(String[] args) throws Exception { | |||
| PerfClientUtils.exit(0); | |||
| } | |||
| } | |||
| if (arguments.numMessages > 0 && totalMessagesReceived.sum() >= arguments.numMessages) { | |||
| log.info("------------------- DONE -----------------------"); | |||
There was a problem hiding this comment.
Could we add a hint that why the perf tool is done?
Such as log.inf("------------------- DONE (reach consume message num in total) -----------------------")
There was a problem hiding this comment.
Good suggestion, I have added hints to all the places where the number of messages and the test duration are reached.
eolivelli
approved these changes
Sep 12, 2021
| if (arguments.numMessages > 0 && totalMessagesReceived.sum() >= arguments.numMessages) { | ||
| log.info("------------------- DONE -----------------------"); | ||
| printAggregatedStats(); | ||
| PerfClientUtils.exit(0); |
There was a problem hiding this comment.
Please add a dummy 'return' statement.
Anonymitaet
reviewed
Sep 13, 2021
site2/docs/reference-cli-tools.md
Outdated
| @@ -437,6 +437,7 @@ Options | |||
| |`-v`, `--encryption-key-value-file`|The file which contains the private key to decrypt payload|| | |||
| |`-h`, `--help`|Help message|false| | |||
| |`--conf-file`|Configuration file|| | |||
| |`-m`, `--num-messages`|Number of messages to consume in total. If <= 0, it will keep consuming.|0| | |||
There was a problem hiding this comment.
Suggested change
| |`-m`, `--num-messages`|Number of messages to consume in total. If <= 0, it will keep consuming.|0| | |
| |`-m`, `--num-messages`|Number of messages to consume in total. If the value is equal to or smaller than 0, it keeps consuming messages.|0| |
There was a problem hiding this comment.
Please keep consistent in other descriptions.
Anonymitaet
added
the
doc
315157973
reviewed
Sep 14, 2021
| @@ -240,7 +238,8 @@ public void run() { | |||
|
|
|||
| // Acquire 1 sec worth of messages to have a slower ramp-up | |||
| rateLimiter.acquire((int) msgRate); | |||
| final long startTime = System.currentTimeMillis(); | |||
| final long startTime = System.nanoTime(); | |||
| final long testEndTime = startTime + (long) (arguments.testTime * 1e9); | |||
There was a problem hiding this comment.
I recommend using TimeUnit.SECONDS.toNanos() instead of 1e9 to make it more understandable to other developers
bharanic-dev
pushed a commit
to bharanic-dev/pulsar
that referenced
this pull request
Mar 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Add new option
--num-messagesfor aconsumerandreaderin pulsar-perf, and allow users to set the number of messages to consume in total.Modifications
--num-messagesinPerformanceConsumerandPerformanceReader--num-messages, directly print the aggregated data and exitDocumentation
Need to update docs