[testclient] Printing aggregated data when client exit #11985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaoran10
reviewed
Sep 12, 2021
| @@ -45,6 +45,7 @@ | |||
| @WebSocket(maxTextMessageSize = 64 * 1024) | |||
| public class SimpleTestProducerSocket { | |||
| public static Recorder recorder = new Recorder(TimeUnit.SECONDS.toMillis(120000), 5); | |||
| public static Recorder cumulativeRecorder = new Recorder(TimeUnit.SECONDS.toMillis(120000), 5); | |||
There was a problem hiding this comment.
I'm not sure why need to add a new field cumulativeRecorder.
There was a problem hiding this comment.
Consistent with other implementations such as PerformanceProducer, PerformanceReader, ManagedLedgerWriter and PerformanceConsumer
There was a problem hiding this comment.
It doesn’t seem to be used in SimpleTestProducerSocket
There was a problem hiding this comment.
I have removed this variable cumulativeRecorder in SimpleTestProducerSocket and directly reuse recorder to get the aggregated data.
There was a problem hiding this comment.
@congbobo184 @gaoran10 Could you take a look again?
yuruguo
changed the title
yuruguo
changed the title
BewareMyPower
approved these changes
Sep 16, 2021
codelipenghui
pushed a commit
that referenced
this pull request
Sep 29, 2021
) (cherry picked from commit 3c770a1)
bharanic-dev
pushed a commit
to bharanic-dev/pulsar
that referenced
this pull request
Mar 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Printing aggregated data includes throughput and delay when the client exits in
PerformanceClient/ManagedLedgerWriterModifications
printAggregatedStatsmethod to print delay data in classPerformanceClientprintAggregatedThroughputandprintAggregatedStatsin classPerformanceClientprintAggregatedThroughputinto ShutdownHook in classManagedLedgerWriterDocumentation