-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade aircompressor to 0.20 #11790
upgrade aircompressor to 0.20 #11790
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
can you follow up with a PR that contains a "git revert" of #11594 ? |
@eolivelli Ok, i am working to revert #11594 , but i will keep the tests. |
|
…r upgrade to 0.20 (#11792) ### Motivation Due to aircompressor 0.19 can't work with heap buffer on JDK1.8, so #11594 use copy data to direct buffer to avoid NoSuchMethodError exception. Now aircompressor released 0.20 and #11790 has upgrade the aircompressor version to 0.20 to fix this issue, we can revert #11594 to avoid copy data to direct buffer to improve performance. ### Modification 1. revert Fix java.lang.NoSuchMethodError: java.nio.ByteBuffer.position(I)Ljava/nio/ByteBuffer when enabling topic metadata compression #11594, but keep the tests.
…r upgrade to 0.20 (#11792) ### Motivation Due to aircompressor 0.19 can't work with heap buffer on JDK1.8, so #11594 use copy data to direct buffer to avoid NoSuchMethodError exception. Now aircompressor released 0.20 and #11790 has upgrade the aircompressor version to 0.20 to fix this issue, we can revert #11594 to avoid copy data to direct buffer to improve performance. ### Modification 1. revert Fix java.lang.NoSuchMethodError: java.nio.ByteBuffer.position(I)Ljava/nio/ByteBuffer when enabling topic metadata compression #11594, but keep the tests. (cherry picked from commit cc1b983)
Fix apache#11789 ### Modification upgrade aircompressor from 0.19 to 0.20
…r upgrade to 0.20 (apache#11792) ### Motivation Due to aircompressor 0.19 can't work with heap buffer on JDK1.8, so apache#11594 use copy data to direct buffer to avoid NoSuchMethodError exception. Now aircompressor released 0.20 and apache#11790 has upgrade the aircompressor version to 0.20 to fix this issue, we can revert apache#11594 to avoid copy data to direct buffer to improve performance. ### Modification 1. revert Fix java.lang.NoSuchMethodError: java.nio.ByteBuffer.position(I)Ljava/nio/ByteBuffer when enabling topic metadata compression apache#11594, but keep the tests.
This reverts commit 5ad16b6.
This reverts commit 5ad16b6.
* Revert "[fix][proxy] Fix client service url (#16834)" This reverts commit 10b4e99. * Revert "[Build] Use grpc-bom to align grpc library versions (#15234)" This reverts commit 99c93d2. * Revert "upgrade aircompressor to 0.20 (#11790)" This reverts commit 5ad16b6. * Revert "[Branch-2.7] Fixed deadlock on metadata cache missing while doing checkReplication (#12484)" This reverts commit 32fe228. * Revert changes of PersistentTopic#getMessageTTL in #12339. Co-authored-by: JiangHaiting <janghaiting@apache.org>
@hangc0276 Please provide a correct documentation label for your PR. |
Move |
Fix #11789
Modification