Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added some missing configs on websocket producer/consumer #1173

Merged
merged 1 commit into from
Feb 5, 2018
Merged

Added some missing configs on websocket producer/consumer #1173

merged 1 commit into from
Feb 5, 2018

Conversation

merlimat
Copy link
Contributor

@merlimat merlimat commented Feb 5, 2018

Motivation

We are missing to expose some config options for producer/consumer in the WebSocket API.

@merlimat merlimat added the doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. label Feb 5, 2018
@merlimat merlimat added this to the 1.22.0-incubating milestone Feb 5, 2018
@merlimat merlimat self-assigned this Feb 5, 2018
@merlimat merlimat requested a review from rdhabalia February 5, 2018 02:44
@merlimat merlimat merged commit 1945799 into apache:master Feb 5, 2018
@merlimat merlimat deleted the more-websocket-configs branch February 5, 2018 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sijie sijie sijie approved these changes

@rdhabalia rdhabalia Awaiting requested review from rdhabalia

Assignees

@merlimat merlimat

Labels
doc Your PR contains doc changes, no matter whether the changes are in markdown or code files.
Projects
None yet
Milestone
1.22.0-incubating
Development

Successfully merging this pull request may close these issues.
2 participants
@merlimat @sijie