-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[website][pulsar-client/pulsar-perf] pulsar-client and pulsar-perf cli doc command flag duplicated #11182
[website][pulsar-client/pulsar-perf] pulsar-client and pulsar-perf cli doc command flag duplicated #11182
Conversation
Signed-off-by: LiLi <urfreespace@gmail.com>
@Anonymitaet @tuteng PTAL, thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/pulsarbot rerun-failure-checks |
@urfreespace thanks for your contribution! |
/pulsarbot rerun-failure-checks |
@315157973 PTAL |
/pulsarbot rerun-failure-checks |
Unrelated test failures
|
/pulsarbot rerun-failure-checks |
1 similar comment
/pulsarbot rerun-failure-checks |
|
/pulsarbot rerun-failure-checks |
Because the test run time exceeds 60 minutes |
…pache#11182) ### Master Issue: apache#10040 ### Motivation Support auto generate HTML page for pulsar client cli tool, for example: https://github.com/apache/pulsar/tree/asf-site/content/tools/pulsar-admin ### Modifications fix duplicated long and short command line parameter names for pulsar-client cli docs fix duplicated long and short command line parameter names for pulsar-perf cli docs
Master Issue: #10040
Motivation
Support auto generate HTML page for pulsar client cli tool, for example: https://github.com/apache/pulsar/tree/asf-site/content/tools/pulsar-admin
Modifications
fix duplicated long and short command line parameter names for pulsar-client cli docs
fix duplicated long and short command line parameter names for pulsar-perf cli docs
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Added integration tests for end-to-end deployment with large payloads (10MB)
Extended integration test for recovery after broker failure
Does this pull request potentially affect one of the following parts:
If yes was chosen, please highlight the changes
Dependencies (does it add or upgrade a dependency): (yes / no)
The public API: (yes / no)
The schema: (yes / no / don't know)
The default values of configurations: (yes / no)
The wire protocol: (yes / no)
The rest endpoints: (yes / no)
The admin cli options: (yes / no)
Anything that affects deployment: (yes / no / don't know)
Documentation
Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
If a feature is not applicable for documentation, explain why?
If a feature is not documented yet in this PR, please create a followup issue for adding the documentation