Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish pulsar-client-admin as a shaded artifact #1095

Merged
merged 1 commit into from
Jan 30, 2018

Conversation

merlimat
Copy link
Contributor

Motivation

Fixes #1091

Publish shaded jar for pulsar-client-admin to avoid conflicts with other dependencies.

@merlimat merlimat added this to the 1.22.0-incubating milestone Jan 23, 2018
@merlimat merlimat self-assigned this Jan 23, 2018
@sschepens
Copy link
Contributor

sschepens commented Jan 24, 2018

Are we going to provide a non shaded artifact?

@merlimat
Copy link
Contributor Author

@sschepens I followed the same path as the pulsar-client: the pulsar-client-admin-original will be published unshaded.

@sschepens
Copy link
Contributor

👍

@merlimat
Copy link
Contributor Author

retest this please

@merlimat merlimat force-pushed the pulsar-admin-shading branch from e09a0a6 to 61ebd7f Compare January 29, 2018 18:51
@merlimat merlimat force-pushed the pulsar-admin-shading branch from 61ebd7f to 15906fc Compare January 30, 2018 06:45
@merlimat merlimat merged commit 650a6b8 into apache:master Jan 30, 2018
@merlimat merlimat deleted the pulsar-admin-shading branch January 30, 2018 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants